#64130 Fix TypeError in wpdb::load_col_info() when a query fails by AKSHAT2802 · Pull Request #13099 · WordPress/wordpress-develop

AKSHAT2802 · 2026-08-17T10:14:12Z

Trac ticket: https://core.trac.wordpress.org/ticket/64130

PR Description

This PR adds a guard to load_col_info() so it returns early when $this->result isn't a mysqli_result, consistent with the existing instanceof mysqli_result check already used in wpdb::flush().

A regression test (test_get_col_info_after_failed_query) is included, which runs an invalid query and then accesses col_info — this reproduces the reported TypeError on unpatched code and passes with the fix applied.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Investigating and confirming the bug against the current trunk, and writing/validating the regression test.

All changes were made and verified by reproducing the failure and confirming the fix in the local test environment.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…add test for get_col_info after failed query

github-actions · 2026-08-17T10:14:22Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props akshat2802, mukesh27, sergeybiryukov, rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-08-17T10:17:21Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

mukeshpanchal27

Thanks for the PR! The fix looks right to me. I reproduced the TypeError on trunk (PHP 8.3) and confirmed this change fixes it.

Fix

! ( $this->result instanceof mysqli_result ) covers every non-result state: false (failed query), true (INSERT/UPDATE/DELETE/SET/etc.) and null (no query yet, or the early return on invalid data in query()).
It matches the existing checks in flush() and query(), and it's stricter than the is_object() check suggested on the ticket.
get_col_info() then returns null, which is what callers already get when there are no columns, so valid usage is unaffected.
As a side note, PHPStan level 7 reports both mysqli_num_fields() and mysqli_fetch_field() here (bool|mysqli_result|null given). Those go away with this change. The project's current level 5 doesn't catch it.

Test suggestions

The test only covers the failed-query (false) case. The more common trigger is probably reading col_info after a write query, where $this->result is true. Could you use a data provider (a static one, like the rest of this file) that also covers UPDATE and SET?
Please add @ticket 64130.
Please save and restore the previous suppression state ($suppress = $wpdb->suppress_errors( true ); … $wpdb->suppress_errors( $suppress );) instead of hardcoding false, as other tests in this file do.
Nit: wptests_ is hardcoded in the table name. Any table name that doesn't exist will work.
Nit: assertFalse( $wpdb->result ) checks a protected property through __get(). The col_info/get_col_info() assertions already cover the behavior, so it could be dropped.

Suggested version:

/**
 * @ticket 64130
 *
 * @dataProvider data_get_col_info_without_result_set
 *
 * @param string $query Query that does not produce a result set.
 */
public function test_get_col_info_without_result_set( $query ) {
	global $wpdb;

	$suppress = $wpdb->suppress_errors( true );
	$wpdb->query( sprintf( $query, $wpdb->options ) );
	$wpdb->suppress_errors( $suppress );

	$this->assertNull( $wpdb->get_col_info(), 'get_col_info() should return null.' );
	$this->assertNull( $wpdb->col_info, 'The col_info property should be null.' );
}

/**
 * Data provider.
 *
 * @return array<string, string[]>
 */
public static function data_get_col_info_without_result_set() {
	return array(
		'failed query' => array( 'SELECT ID FROM table_that_does_not_exist' ),
		'update query' => array( "UPDATE %s SET option_value = option_value WHERE option_name = 'blogname'" ),
		'set query'    => array( 'SET @wp_test_64130 = 1' ),
	);
}

I ran this locally. With the fix, all 3 cases pass. Without it, all 3 fail with TypeError: mysqli_num_fields(): Argument #1 ($result) must be of type mysqli_result, {false|true} given.

refactor order Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>

rejaulalomkhan · 2026-10-16T00:50:30Z

Thanks for working on this, @AKSHAT2802! Covering UPDATE and SET queries, not only failed ones, is what makes these tests useful. I tested it locally:

Patch Testing Report

Patch tested: #13099

Environment

WordPress: 7.2-alpha-63166-src
PHP: 8.3.35
Server: PHP CLI (PHPUnit 9.6.38)
Database: MySQL 8.4.11
Browser: N/A (unit tests)
OS: macOS (wordpress-develop Docker environment)
Theme: N/A
MU Plugins: None activated
Plugins: None activated

Steps taken

Applied only the new tests to current trunk and ran npm run test:php -- --filter test_get_col_info_without_result_set → all 3 data sets error with TypeError: mysqli_num_fields(): Argument #1 ($result) must be of type mysqli_result (false given for the failed query, true given for UPDATE and SET).
Applied the full PR → the 3 tests pass on single site and multisite.
Ran the wpdb group on single site and multisite, and in random order: 654 tests, no failures (2 skipped, same as trunk).
Changed the guard to only false === $this->result → the update query and set query data sets fail, so the tests also catch a fix that handles failed queries only; reverted.
✅ Patch is solving the problem: get_col_info() and $wpdb->col_info return null instead of throwing a TypeError when the last query has no result set.

Expected result

Reading column info after a query without a result set (failed query, UPDATE, SET) returns null instead of throwing a TypeError.

Additional Notes

The new guard matches the existing $this->result instanceof mysqli_result checks in wpdb::flush() and wpdb::query().
AI assistance: Claude Code was used to run the tests; results reviewed by me.

…t is not set. This resolves an error if `mysqli_num_fields()` is called before a successful SELECT-type query is performed: {{{ mysqli_num_fields(): Argument #1 ($result) must be of type mysqli_result, false given }}} Developed in #13099. Follow-up to r21472. Props joehorntw, akshat2802, mukesh27, rejaulalomkhan, SergeyBiryukov. Fixes #64130. git-svn-id: https://develop.svn.wordpress.org/trunk@64458 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2026-10-17T23:22:16Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 64458
GitHub commit: 2695d61

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

…t is not set. This resolves an error if `mysqli_num_fields()` is called before a successful SELECT-type query is performed: {{{ mysqli_num_fields(): Argument #1 ($result) must be of type mysqli_result, false given }}} Developed in WordPress/wordpress-develop#13099. Follow-up to r21472. Props joehorntw, akshat2802, mukesh27, rejaulalomkhan, SergeyBiryukov. Fixes #64130. Built from https://develop.svn.wordpress.org/trunk@64458 git-svn-id: http://core.svn.wordpress.org/trunk@63608 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Enhance load_col_info method to check for mysqli_result instance and …

dbe5857

…add test for get_col_info after failed query

AKSHAT2802 added 2 commits August 24, 2026 08:16

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

70eef38

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

3687c99

mukeshpanchal27 reviewed Sep 30, 2026

View reviewed changes

AKSHAT2802 and others added 3 commits October 1, 2026 00:17

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

dbb2dbe

Tests: Add test for get_col_info() with failed queries

08c1b67

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

574e8ca

AKSHAT2802 requested a review from mukeshpanchal27 October 1, 2026 07:05

mukeshpanchal27 reviewed Oct 1, 2026

View reviewed changes

Comment thread tests/phpunit/tests/db.php

AKSHAT2802 and others added 2 commits October 1, 2026 15:07

Update tests/phpunit/tests/db.php

3dea525

refactor order Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

1d5b1b7

AKSHAT2802 requested a review from mukeshpanchal27 October 1, 2026 09:38

mukeshpanchal27 approved these changes Oct 3, 2026

View reviewed changes

mukeshpanchal27 requested a review from SergeyBiryukov October 3, 2026 05:22

AKSHAT2802 added 2 commits October 4, 2026 02:14

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

e29b4e9

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

501c500

SergeyBiryukov approved these changes Oct 7, 2026

View reviewed changes

AKSHAT2802 added 2 commits October 8, 2026 10:54

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

aab7aa7

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

2a89d49

Merge branch 'trunk' into fix/64130-wpdb-load-col-info-type-check

23010e6

github-actions Bot closed this Oct 17, 2026

Navigation Menu

Repository navigation

#64130 Fix TypeError in wpdb::load_col_info() when a query fails - #13099

#64130 Fix TypeError in wpdb::load_col_info() when a query fails#13099
AKSHAT2802 wants to merge 13 commits into
WordPress:trunkfrom
AKSHAT2802:fix/64130-wpdb-load-col-info-type-check

AKSHAT2802 commented Aug 17, 2026

Uh oh!

github-actions Bot commented Aug 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

mukeshpanchal27 left a comment

Uh oh!

Uh oh!

rejaulalomkhan commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AKSHAT2802 commented Aug 17, 2026

PR Description

Use of AI Tools

Uh oh!

github-actions Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 17, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rejaulalomkhan commented Oct 16, 2026

Patch Testing Report

Environment

Steps taken

Expected result

Additional Notes

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Aug 17, 2026 •

edited

Loading