Skip to content

REST API: Log suppressed diagnostic messages to the debug log - #12531

Closed
deepakpra wants to merge 1 commit into
WordPress:trunkfrom
deepakpra:fix/rest-api-debug-logging
Closed

deepakpra wants to merge 1 commit into
WordPress:trunkfrom
deepakpra:fix/rest-api-debug-logging

Conversation

@deepakpra

Copy link
Copy Markdown

REST API requests suppress the native _doing_it_wrong() and deprecation error paths to prevent PHP notices from corrupting JSON responses. As a result, these diagnostics are also missing from the debug log.

This PR logs REST API diagnostic messages when WP_DEBUG and WP_DEBUG_LOG are enabled, while continuing to suppress output that could corrupt REST responses.

The changes:

  • Log _doing_it_wrong() messages as PHP Notice.
  • Log deprecated function and argument messages as PHP Deprecated.
  • Respect the configured error_reporting() levels.
  • Remove HTML markup from plain-text log messages.
  • Include the responsible function, file, and line when the call originates under WP_CONTENT_DIR.
  • Handle anonymous functions and calls from a file's global scope.
  • Normalize paths for cross-platform compatibility.
  • Continue sending diagnostic headers when headers have not already been sent.
  • Allow debug logging to continue after headers have been sent.
  • Add PHPUnit coverage for logging, severity filtering, disabled logging, caller information, anonymous functions, and global-scope calls.

Testing

Run the REST API PHPUnit tests:

npm run test:php -- --filter Tests_REST_API

@deepakpra
deepakpra marked this pull request as draft July 15, 2026 05:36
@github-actions

Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props deepakprajapati.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@deepakpra deepakpra closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant