Repository navigation
Remove function_exists( 'ini_get' ) checks - #12351
shreyasikhar wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
siliconforks
left a comment
siliconforks
left a comment
There was a problem hiding this comment.
Other than the one requested change, everything else in this PR looks good.
| } | ||
|
|
||
| if ( null === $max_execution_time ) { | ||
| // Keep the previous behavior but attempt to prevent fatal errors from timeout if possible. |
There was a problem hiding this comment.
I think this comment ("Keep the previous behavior but attempt to prevent fatal errors from timeout if possible") should be retained. It's referring to the code in the entire branch, not the function_exists() check.
There was a problem hiding this comment.
Thanks @siliconforks, I have added back the requested inline comment 0574edb
siliconforks
left a comment
siliconforks
left a comment
There was a problem hiding this comment.
Thanks, I think this PR is ready to merge now.
Summary
Removes all
function_exists( 'ini_get' )guards from the codebase. These checks are dead code:ini_get()is called unconditionally inwp_initial_constants()during early boot, so WordPress would fatal error long before any of these guarded code paths are reached on environments whereini_getis disabled. The guards therefore provide no practical protection and only add noise.The one remaining
function_exists( 'ini_get_all' )check is intentionally left in place, asini_get_all()is a distinct function that is not called unconditionally on boot.Trac ticket
https://core.trac.wordpress.org/ticket/65423
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 4.6