Skip to content

Formatting: Prevent PHP 8.1 deprecation when passing null to esc_url() #12132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dervish12 wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Formatting: Prevent PHP 8.1 deprecation when passing null to esc_url() #12132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45838c
Formatting: Prevent PHP 8.1 deprecation when passing null to esc_url()
Dervish12 Jun 9, 2026
081c414
Merge branch 'trunk' into trac/esc-url-null-deprecation
Dervish12 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-includes/formatting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4538,8 +4538,8 @@ function esc_sql( $data ) {
function esc_url( $url, $protocols = null, $_context = 'display' ) {
$original_url = $url;

if ( '' === $url ) {
return $url;
if ( '' === $url || null === $url ) {
return '';
}

$url = str_replace( ' ', '%20', ltrim( $url ) );
Expand Down
22 changes: 22 additions & 0 deletions tests/phpunit/tests/formatting/escUrl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,4 +311,26 @@ public function test_ipv6_hosts() {
$this->assertSame( '//[::FFFF::127.0.0.1]/?foo%5Bbar%5D=baz', esc_url( '//[::FFFF::127.0.0.1]/?foo[bar]=baz' ) );
$this->assertSame( 'http://[::FFFF::127.0.0.1]/?foo%5Bbar%5D=baz', esc_url( 'http://[::FFFF::127.0.0.1]/?foo[bar]=baz' ) );
}

/**
* Test that esc_url() handles null input without triggering
* a PHP 8.1 "passing null to non-nullable" deprecation.
*
* @ticket 65432
*/
public function test_null_input_returns_empty_string() {
$this->assertSame( '', esc_url( null ) );
}

/**
* Test that sanitize_url() handles null input without triggering
* a PHP 8.1 "passing null to non-nullable" deprecation.
*
* @ticket 65432
*
* @covers ::sanitize_url
*/
public function test_sanitize_url_null_input_returns_empty_string() {
$this->assertSame( '', sanitize_url( null ) );
}
}
Loading