Skip to content

AI Client: fix sendRequestWithOptions error message inconsistency and add missing tests #12108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagarsdeshmukh wants to merge 6 commits into from
Closed

AI Client: fix sendRequestWithOptions error message inconsistency and add missing tests #12108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84dce0b
AI Client: fix sendRequestWithOptions error message inconsistency and…
sagarsdeshmukh Jun 5, 2026
ec24d99
Merge branch 'trunk' into fix/ai-client-http-error-message-and-tests
sagarsdeshmukh Jun 5, 2026
87a752b
Merge branch 'trunk' into fix/ai-client-http-error-message-and-tests
gziolo Jul 13, 2026
3ce9c85
Remove duplicated test
gziolo Jul 13, 2026
62b9528
Update tests/phpunit/tests/ai-client/wpAiClientHttpClient.php
gziolo Jul 15, 2026
3224bf4
Merge branch 'trunk' into fix/ai-client-http-error-message-and-tests
gziolo Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/wp-includes/ai-client/adapters/class-wp-ai-client-http-client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,9 @@ public function sendRequestWithOptions( RequestInterface $request, RequestOption

if ( is_wp_error( $response ) ) {
$message = sprintf(
/* translators: 1: Request URL. 2: Error message. */
__( 'Network error occurred while sending request to %1$s: %2$s' ),
/* translators: 1: HTTP method (e.g. GET, POST). 2: Request URL. 3: Error message. */
__( 'Network error occurred while sending %1$s request to %2$s: %3$s' ),
$request->getMethod(),
$url,
$response->get_error_message()
);
Expand Down
26 changes: 26 additions & 0 deletions tests/phpunit/tests/ai-client/wpAiClientHttpClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,32 @@ static function () {
$this->client->sendRequestWithOptions( $request, $options );
}

/**
* Test that sendRequestWithOptions includes the HTTP method in the NetworkException message.
*
* @ticket 65421
*/
public function test_send_request_with_options_wp_error_message_includes_method() {
add_filter(
'pre_http_request',
static function () {
return new WP_Error( 'http_request_failed', 'Connection refused' );
}
);

$options = new WordPress\AiClient\Providers\Http\DTO\RequestOptions();
$request = $this->psr17_factory->createRequest( 'POST', 'https://api.example.com/generate' );

try {
$this->client->sendRequestWithOptions( $request, $options );
$this->fail( 'Expected NetworkException was not thrown.' );
} catch ( WordPress\AiClient\Providers\Http\Exception\NetworkException $e ) {
$this->assertStringContainsString( 'POST', $e->getMessage() );
$this->assertStringContainsString( 'https://api.example.com/generate', $e->getMessage() );
$this->assertStringContainsString( 'Connection refused', $e->getMessage() );
}
}

/**
* Test seekable body is rewound before sending.
*
Expand Down
Loading