Skip to content

Bundled Theme: Twenty Thirteen: scope .sidebar .entry-meta to .hentry > to avoid compressing block-rendered meta - #11929

Open
Gustavo-Hilario wants to merge 2 commits into
WordPress:trunkfrom
Gustavo-Hilario:fix/twentythirteen-sidebar-entry-meta-scoped
Open

Gustavo-Hilario wants to merge 2 commits into
WordPress:trunkfrom
Gustavo-Hilario:fix/twentythirteen-sidebar-entry-meta-scoped

Conversation

@Gustavo-Hilario

@Gustavo-Hilario Gustavo-Hilario commented May 21, 2026 •

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/65306

Description

In wp-content/themes/twentythirteen/style.css (and rtl.css), the rule:

.sidebar .entry-header,
.sidebar .entry-content,
.sidebar .entry-summary,
.sidebar .entry-meta {
    max-width: 1040px;
    padding: 0 376px 0 60px;
}

applies a 376px right padding to any descendant .entry-meta (or .entry-content / .entry-summary / .entry-header) when the Secondary Widget Area is active. Block-rendered .entry-meta markup (e.g. emitted by a block plugin that uses the same class) inherits the padding and is squeezed into ~168px of usable width.

This PR scopes each selector to a direct child of .hentry, so only the theme's own classic-template .entry-meta is affected. Block-emitted .entry-meta nested elsewhere no longer matches.

Steps to reproduce

  1. Activate Twenty Thirteen on a self-hosted install.
  2. Add a widget to the Secondary Widget Area.
  3. Create a page with a Custom HTML block containing:
    <div class="entry-meta">By <a href="#">Author</a> • <time>May 21, 2026</time></div>
    
  4. Before this patch: author/date is squeezed into ~168px on the left. After: full width.

Verification

  • Custom HTML block page with .entry-meta: no longer compressed.
  • Single post: theme's own footer .entry-meta + .entry-content still 376px right padding / 1040px max-width.
  • Category archive: each entry preserves sidebar layout.
  • RTL (rtl.css): mirrored fix; theme own meta retains the inverted padding.

Files

  • src/wp-content/themes/twentythirteen/style.css
  • src/wp-content/themes/twentythirteen/rtl.css

@github-actions

Copy link
Copy Markdown

Hi @Gustavo-Hilario! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Gustavo-Hilario
Gustavo-Hilario force-pushed the fix/twentythirteen-sidebar-entry-meta-scoped branch from 3af704e to 46d633b Compare May 21, 2026 16:54
@Gustavo-Hilario
Gustavo-Hilario marked this pull request as ready for review May 21, 2026 16:54
@github-actions

github-actions Bot commented May 21, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gustavohappyeng, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment on lines +152 to +155
.sidebar .hentry > .entry-header,
.sidebar .hentry > .entry-content,
.sidebar .hentry > .entry-summary,
.sidebar .hentry > .entry-meta {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid increasing specificity, in case people override the styles.

Suggested change
.sidebar .hentry > .entry-header,
.sidebar .hentry > .entry-content,
.sidebar .hentry > .entry-summary,
.sidebar .hentry > .entry-meta {
:where(.sidebar) .hentry > .entry-header,
:where(.sidebar) .hentry > .entry-content,
:where(.sidebar) .hentry > .entry-summary,
:where(.sidebar) .hentry > .entry-meta {

or possibly

.sidebar .entry-meta:where(footer)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Adopted the :where(.sidebar) form in both style.css and rtl.css — pushed in the amended commit. Specificity is back at (0,2,0), matching the original selector.

… > to avoid compressing block-rendered meta.

The descendant selector `.sidebar .entry-meta` (and siblings .entry-header / .entry-content / .entry-summary) applies a 376px right padding to any matching element when the Secondary Widget Area is active. Block-rendered `.entry-meta` (e.g. emitted by block plugins such as Newspack Blog Posts, or any custom block markup) inherits the padding and is squeezed into ~168px.

Scoping each selector to `.hentry > ` preserves the theme's own classic-template layout while leaving block-emitted .entry-meta unaffected. Same change mirrored in rtl.css.

Props gustavohilario.
Fixes #65306.
@Gustavo-Hilario
Gustavo-Hilario force-pushed the fix/twentythirteen-sidebar-entry-meta-scoped branch from 46d633b to ca065b8 Compare May 21, 2026 20:51
@sabernhardt

Copy link
Copy Markdown

The .hentry class is a problem because the post class list is filtered. For example, WooCommerce removes the hentry post class from product posts, and SiteSEO has an advanced option to remove it from any post. Any other class name might have the same problem too.

Twenty Thirteen's stylesheet already removes the extra padding in .entry-header with a separate ruleset, and I think it should have something similar for widgets (at the end of the '6.1 Widgets' section).

.sidebar .entry-header .entry-meta {
padding: 0;
}

If the new ruleset would list all 4 entry- classes together at a specificity of 0-2-0, it would need to be added again in rtl.css.

.sidebar .widget :where(.entry-header, .entry-content, .entry-summary, .entry-meta) {
	padding: 0;
}

@sabernhardt

Copy link
Copy Markdown

For testing, I searched for a plugin that assigns the entry-meta class within a block. (If this had only occurred in Custom HTML, it probably would not be worth editing a stylesheet used by thousands of sites.)

  • Gutentor has a "Post Widget" that includes an entry-meta class.
  • Kadence Blocks' "Posts" block can include entry-header, entry-summary, and entry-meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants