Repository navigation
Bundled Theme: Twenty Thirteen: scope .sidebar .entry-meta to .hentry > to avoid compressing block-rendered meta - #11929
Conversation
|
Hi @Gustavo-Hilario! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
3af704e to
46d633b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| .sidebar .hentry > .entry-header, | ||
| .sidebar .hentry > .entry-content, | ||
| .sidebar .hentry > .entry-summary, | ||
| .sidebar .hentry > .entry-meta { |
There was a problem hiding this comment.
Avoid increasing specificity, in case people override the styles.
| .sidebar .hentry > .entry-header, | |
| .sidebar .hentry > .entry-content, | |
| .sidebar .hentry > .entry-summary, | |
| .sidebar .hentry > .entry-meta { | |
| :where(.sidebar) .hentry > .entry-header, | |
| :where(.sidebar) .hentry > .entry-content, | |
| :where(.sidebar) .hentry > .entry-summary, | |
| :where(.sidebar) .hentry > .entry-meta { |
or possibly
.sidebar .entry-meta:where(footer)
There was a problem hiding this comment.
Thanks for the review. Adopted the :where(.sidebar) form in both style.css and rtl.css — pushed in the amended commit. Specificity is back at (0,2,0), matching the original selector.
… > to avoid compressing block-rendered meta. The descendant selector `.sidebar .entry-meta` (and siblings .entry-header / .entry-content / .entry-summary) applies a 376px right padding to any matching element when the Secondary Widget Area is active. Block-rendered `.entry-meta` (e.g. emitted by block plugins such as Newspack Blog Posts, or any custom block markup) inherits the padding and is squeezed into ~168px. Scoping each selector to `.hentry > ` preserves the theme's own classic-template layout while leaving block-emitted .entry-meta unaffected. Same change mirrored in rtl.css. Props gustavohilario. Fixes #65306.
46d633b to
ca065b8
Compare
|
The Twenty Thirteen's stylesheet already removes the extra padding in wordpress-develop/src/wp-content/themes/twentythirteen/style.css Lines 1042 to 1044 in 7920dd0 If the new ruleset would list all 4 |
|
For testing, I searched for a plugin that assigns the
|
Trac ticket: https://core.trac.wordpress.org/ticket/65306
Description
In
wp-content/themes/twentythirteen/style.css(andrtl.css), the rule:applies a 376px right padding to any descendant
.entry-meta(or.entry-content/.entry-summary/.entry-header) when the Secondary Widget Area is active. Block-rendered.entry-metamarkup (e.g. emitted by a block plugin that uses the same class) inherits the padding and is squeezed into ~168px of usable width.This PR scopes each selector to a direct child of
.hentry, so only the theme's own classic-template.entry-metais affected. Block-emitted.entry-metanested elsewhere no longer matches.Steps to reproduce
Verification
.entry-meta: no longer compressed..entry-meta+.entry-contentstill 376px right padding / 1040px max-width.rtl.css): mirrored fix; theme own meta retains the inverted padding.Files
src/wp-content/themes/twentythirteen/style.csssrc/wp-content/themes/twentythirteen/rtl.css