Repository navigation
Date/Time: Fix swapped variable names and comments in get_weekstartend(). - #11504
saratheonline wants to merge 5 commits into
Conversation
…d().
The variables `$mm` and `$md` had their substr() positions and inline
comments swapped — `$mm` was extracting the day digits (position 8)
while `$md` was extracting the month digits (position 5), contrary to
what the comments indicated.
The output was accidentally correct because the two mistakes cancelled
each other out in the mktime() call, but the misleading naming posed
a future maintenance risk.
Corrects the substr() positions and mktime() argument order so that
variable names, comments, and logic are all consistent.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Part of the problem with the original code is the use of the very short abbreviated variables make it difficult to read and understand to begin with. Please also update the variables to use full words so that it is obvious what values they contain. |
I have updated the variable names to descriptive full names. |
There was a problem hiding this comment.
Pull request overview
This PR corrects the internal variable naming and inline comments in get_weekstartend() so the parsed year/month/day components now match the actual substr offsets and mktime() argument order. It is a small maintenance fix in WordPress core’s date/time utilities that improves clarity without changing the intended output of the function.
Changes:
- Rename the extracted date-part variables in
get_weekstartend()to descriptive names. - Fix the month/day
substr()offsets so they align with the variable names and comments. - Update the
mktime()call to pass the corrected month/day/year variables in the matching order.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
We'll queue this up to commit once trunk is unfrozen for 7.1.
Trac ticket: https://core.trac.wordpress.org/ticket/65046
The variables
$mmand$mdhad their substr() positions and inlinecomments swapped —
$mmwas extracting the day digits (position 8)while
$mdwas extracting the month digits (position 5), contrary towhat the comments indicated.
The output was accidentally correct because the two mistakes cancelled
each other out in the mktime() call, but the misleading naming posed
a future maintenance risk.
Corrects the substr() positions and mktime() argument order so that
variable names, comments, and logic are all consistent.
Fixes #65046
The variables
$mmand$mdhad their substr() positions and inlinecomments swapped —
$mmwas extracting the day digits (position 8)while
$mdwas extracting the month digits (position 5), contrary towhat the comments indicated.
The output was accidentally correct because the two mistakes cancelled
each other out in the mktime() call, but the misleading naming posed
a future maintenance risk.
Corrects the substr() positions and mktime() argument order so that
variable names, comments, and logic are all consistent.
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.