Skip to content

Registration: Reject usernames that contain "www." - #11439

Closed
cweiske wants to merge 1 commit into
WordPress:trunkfrom
cweiske:63085-registration-spam
Closed

cweiske wants to merge 1 commit into
WordPress:trunkfrom
cweiske:63085-registration-spam

Conversation

@cweiske

@cweiske cweiske commented Apr 3, 2026

Copy link
Copy Markdown

Wordpress registration e-mails are used to send bitcoin spam to people - by using usernames with spaces like

www.spammer.example.com - 1.2342 BTC

This patch filters out usernames that begin with "www." or contain " www." - such names are auto-linked by email clients and made clickable.

Documented occurences of that spamming problem:

Fixes #63085.

Trac ticket: https://core.trac.wordpress.org/ticket/63085

Use of AI Tools

AI assistance: No


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@cweiske
cweiske force-pushed the 63085-registration-spam branch from 4a3e9d4 to 2e11c32 Compare April 3, 2026 18:11
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

Hi @cweiske! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props cweiske.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@cweiske
cweiske force-pushed the 63085-registration-spam branch 4 times, most recently from 054ee11 to 3a63f3b Compare April 4, 2026 17:19
@cweiske

cweiske commented Apr 4, 2026

Copy link
Copy Markdown
Author

I've added a unit test.

@cweiske

cweiske commented Apr 4, 2026

Copy link
Copy Markdown
Author

The tests failure is a flake; it has nothing to do with my code.

@cweiske
cweiske force-pushed the 63085-registration-spam branch from 3a63f3b to 33a14e4 Compare April 5, 2026 07:12
Wordpress registration e-mails are used to send bitcoin spam to
people - by using usernames with spaces like
> www.spammer.example.com - 1.2342 BTC

This patch filters out usernames that begin with "www."
or contain " www." - such names are auto-linked by email
clients and made clickable.

Documented occurences of that spamming problem:
- https://cweiske.de/tagebuch/wordpress-registration-spam.htm
- https://www.reddit.com/r/Wordpress/comments/1gyyhx7/spammed_with_100_fake_wordpress_login_emails_help/

Fixes #63085.
@cweiske
cweiske force-pushed the 63085-registration-spam branch from 33a14e4 to 81d882b Compare May 18, 2026 05:18
@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62590
GitHub commit: cd441a6

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant