Skip to content

Alternative approach: Fix Copied! text is misaligned - #11421

Closed
mukeshpanchal27 wants to merge 2 commits into
WordPress:trunkfrom
mukeshpanchal27:fix/65009
Closed

mukeshpanchal27 wants to merge 2 commits into
WordPress:trunkfrom
mukeshpanchal27:fix/65009

Conversation

@mukeshpanchal27

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/65009

Use of AI Tools

No


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Apr 1, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27, wildworks, audrasjb, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27

Copy link
Copy Markdown
Member Author

After PR changes:

Screenshot 2026-04-01 at 4 44 40 PM

@mukeshpanchal27
mukeshpanchal27 requested a review from t-hamano April 1, 2026 11:16
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

If we are using flex layout, I believe flex-wrap: wrap is necessary. Otherwise, the button's shape will change significantly when pressed.

63a255817cd5f3f94073dae0454590f8.mp4

Additionally, by removing padding-right: 1em and adding gap: 1em to the flex wrapper, we might achieve appropriate spacing even in mobile layouts when text and buttons are placed vertically.

@mukeshpanchal27
mukeshpanchal27 requested a review from t-hamano April 1, 2026 11:54
@audrasjb

audrasjb commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

This looks good to me on both desktop:
Capture d’écran 2026-04-01 à 16 55 35

and mobile:
Capture d’écran 2026-04-01 à 16 55 09

oops, the text disappeared on the mobile screenshot. But well, trust me it looked good! ^^'

@shail-mehta

Copy link
Copy Markdown
Member
  • Privacy: ”Copied!” Text is now aligned✅
Before After
before-patch after-patch

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62196
GitHub commit: b5da8de

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants