Admin reskin: Remove line-height from input elements by t-hamano · Pull Request #11383 · WordPress/wordpress-develop

t-hamano · 2026-03-28T07:18:30Z

Trac ticket: https://core.trac.wordpress.org/ticket/64763

Use of AI Tools

AI assistance: Yes
Tool(s): Claude

github-actions · 2026-03-28T07:18:42Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-03-28T07:22:06Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

t-hamano

I will explain which UI each change corresponds to. Also, note that select elements are out of scope in this PR, unless input and select are included in the same selector.

t-hamano · 2026-03-28T07:21:16Z

src/wp-admin/css/common.css


 .wp-filter .search-form input[type="search"] {
 	min-height: 32px;
-	line-height: 2.14285714; /* 30px for 32px height with 14px font */


Plugins > Add Plugin > "Search Plugins" field

t-hamano · 2026-03-28T07:23:57Z

src/wp-admin/css/customize-controls.css

 }

 .themes-filter-bar .wp-filter-search {
-	line-height: 2.14285714; /* 30px for 32px compact input */


Activate classic theme > Appearance > Customize > Click "Change" button > "Search Plugins" field

t-hamano · 2026-03-28T07:25:21Z

src/wp-admin/css/dashboard.css

 	width: 40%;
 	margin: 0;
 	min-height: 32px;
-	line-height: 2.14285714;


Dashboard > WordPress Events and News > Click "Select location"

t-hamano · 2026-03-28T07:25:41Z

src/wp-admin/css/forms.css

 input[type="week"] {
 	padding: 0 12px;
 	/* inherits font size 14px */
-	line-height: 2.71428571; /* 38px for 40px min-height */


This is the basic style for the input element.

t-hamano · 2026-03-28T07:31:49Z

src/wp-admin/css/forms.css

 		-webkit-appearance: none;
 		padding: 0 12px;
 		min-height: 40px;
-		line-height: 2.5; /* 40px for 16px font */


This is the basic style for mobile viewports.

t-hamano · 2026-03-28T07:32:45Z

src/wp-admin/css/forms.css

 p.search-box input[type="search"],
 p.search-box input[type="text"] {
 	min-height: 32px;
-	line-height: 2.14285714; /* 30px for 32px height with 14px font */


Search posts

t-hamano · 2026-03-28T07:33:25Z

src/wp-admin/css/list-tables.css

 	font-size: 13px;
 	text-align: center;
 	min-height: 32px;
-	line-height: 2.30769231; /* 30px for 32px height with 13px font */


Pagination input field

t-hamano · 2026-03-28T07:33:52Z

src/wp-admin/css/list-tables.css


 .inline-edit-row select,
 .inline-edit-row input:where(:not([type=checkbox],[type=radio],[type=submit],[type=button])) {
-	line-height: 2.14285714;


Quick edit form

t-hamano · 2026-03-28T07:34:58Z

src/wp-admin/css/media.css


 .media-frame.mode-grid .media-toolbar input[type="search"] {
 	min-height: 32px;
-	line-height: 2.14285714; /* 30px for 32px height with 14px font */


Media > Switch to Grid View > Search media field

audrasjb · 2026-03-28T08:51:42Z

Thanks for the PR! I spotted two more occurrences.

General settings:

Colorpicker:

Otherwise the rest looks good to me!

t-hamano · 2026-03-28T10:47:02Z

Nice catch!

Colorpicker:

Addressed in ea7f3d0

General settings:

Addressed in 935dd5e

Simply removing the line-height changes the input field's height from 26px to 24px. This value is considered small in our design system, but the field feels too tiny:

Therefore, I removed the line-height and increased the height from 26px to 32px. What do you think?

audrasjb · 2026-03-28T11:30:35Z

Looking great to me, thanks!

github-actions · 2026-03-28T12:27:16Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62171
GitHub commit: 19d4be9

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

t-hamano added 2 commits March 28, 2026 16:12

Admin reskin: Remove line-height from input elements

7e8a286

Fix more places

14ce6d7

t-hamano marked this pull request as draft March 28, 2026 07:18

Don't remove line-height for select elements

24c630f

t-hamano force-pushed the 64763-remove-line-height branch from a7f2c63 to 24c630f Compare March 28, 2026 07:29

t-hamano commented Mar 28, 2026

View reviewed changes

t-hamano changed the title ~~64763 remove line height~~ Admin reskin: Remove line-height from input elements Mar 28, 2026

t-hamano marked this pull request as ready for review March 28, 2026 07:35

t-hamano mentioned this pull request Mar 28, 2026

Admin reskin: Remove line-height from input elements. Fixes #64763. #11246

Closed

t-hamano added 2 commits March 28, 2026 19:37

Remove line-height from the color picker

ea7f3d0

Increase height for date and time format input

935dd5e

audrasjb approved these changes Mar 28, 2026

View reviewed changes

github-actions bot closed this Mar 28, 2026

Conversation

t-hamano commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use of AI Tools

Uh oh!

github-actions bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audrasjb commented Mar 28, 2026

Uh oh!

t-hamano commented Mar 28, 2026

Uh oh!

audrasjb commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

t-hamano commented Mar 28, 2026 •

edited

Loading

github-actions bot commented Mar 28, 2026 •

edited

Loading