Skip to content

Bundled Themes: Prevent Twenty Fourteen from hiding featured tag during REST requests#11372

Open
roshniahuja wants to merge 1 commit intoWordPress:trunkfrom
roshniahuja:trac-64882
Open

Bundled Themes: Prevent Twenty Fourteen from hiding featured tag during REST requests#11372
roshniahuja wants to merge 1 commit intoWordPress:trunkfrom
roshniahuja:trac-64882

Conversation

@roshniahuja
Copy link
Copy Markdown

Summary

  • Fixes the "featured" tag being stripped from posts when saved in the block editor with Twenty Fourteen theme
  • Added wp_is_serving_rest_request() check alongside is_admin() in both hide_featured_term() and hide_the_featured_term() methods
  • Uses function_exists() guard for backward compatibility with WordPress < 6.5

Trac Ticket

https://core.trac.wordpress.org/ticket/64882

Test Plan

  1. Activate Twenty Fourteen theme
  2. Go to Appearance → Customize → Featured Content, set tag to "featured", enable "Hide tag"
  3. Create a post with the "featured" tag
  4. Open the post in block editor — the tag should be visible
  5. Save the post — the "featured" tag should be preserved
  6. Visit /wp-json/wp/v2/posts/{id} — tags array should include the featured tag ID

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props roshniahuja14.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@roshniahuja
Copy link
Copy Markdown
Author

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Tested in Playground and working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant