Skip to content

Toolbar color schemes on front end without global variable#11354

Open
sabernhardt wants to merge 12 commits intoWordPress:trunkfrom
sabernhardt:toolbar-sass-front-end
Open

Toolbar color schemes on front end without global variable#11354
sabernhardt wants to merge 12 commits intoWordPress:trunkfrom
sabernhardt:toolbar-sass-front-end

Conversation

@sabernhardt
Copy link
Copy Markdown

Alternative option to #11267 that uses the same Sass and built stylesheets but avoids using the $_wp_admin_css_colors global variable.

  • Reverts the unit test to its original code.
  • Does not enqueue a stylesheet for the Fresh color scheme.
  • Enqueues an external stylesheet for the other 8 core schemes on the front end.
  • Does not attempt to support plugins' color schemes on the front.

Trac 64762

Use of AI Tools

@johnbillion shared these details:

Claude Code was used to initialise the separate admin bar color Sass files for each colour scheme. Worked ok-ish, I subsequently manually adjusted a lot of it.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants