Skip to content

Login: Replace legacy hover colors for links#11284

Closed
nikunj8866 wants to merge 4 commits intoWordPress:trunkfrom
nikunj8866:patch/64879
Closed

Login: Replace legacy hover colors for links#11284
nikunj8866 wants to merge 4 commits intoWordPress:trunkfrom
nikunj8866:patch/64879

Conversation

@nikunj8866
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/64879

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nikunj8866, wildworks, audrasjb, huzaifaalmesbah, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@huzaifaalmesbah
Copy link
Copy Markdown
Member

I noticed that some CSS was removed, including text-decoration: none;. Because of this, the display now looks like this, which doesn’t look good. Also, the hover state and the normal state have the same color, which makes the UI look poor.

Huzaifa-20260318132041

@t-hamano
Copy link
Copy Markdown
Contributor

@nikunj8866 Thanks for working on this.

Please note that only the color needs to be changed here. Any other changes are outside the scope of this ticket.

@nikunj8866
Copy link
Copy Markdown
Author

I've added text-decoration: none; and set the link color to match the default theme color.

@nikunj8866 nikunj8866 requested a review from audrasjb March 18, 2026 11:50
@shail-mehta
Copy link
Copy Markdown
Member

The login page link hover color is aligned with the new theme color scheme.✅

Before After
before-patch after-patch

@t-hamano
Copy link
Copy Markdown
Contributor

The default color has changed. This is not the style that was expected.

Before After
image image

Copy link
Copy Markdown
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is overreaching the intended change; the hover color needs to change, but it is not necessary to also change all of the link colors. Those changes are reasonable enhancements, but beyond the scope of what I think we should do at this stage.

Can we strip this down to only changing the hover state? Other link colors should remain.

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62113
GitHub commit: ae535b3

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants