Prefix the search icon to the keyboard shortcut#11274
Prefix the search icon to the keyboard shortcut#11274t-hamano wants to merge 6 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sabernhardt
left a comment
There was a problem hiding this comment.
Additional edit: setting the icon <span> to block display seems unnecessary on smaller screens because this PR removes display: none:
#wpadminbar #wp-admin-bar-command-palette .ab-icon {
display: block; /* Icon is only shown on mobile, while the keyboard shortcut is hidden */
}
If that ruleset still helps, at least the comment needs updating (remove "only").
Nice catch, removed in 5252f64 |

Before
After
Trac ticket: https://core.trac.wordpress.org/ticket/64672
Use of AI Tools
None