Skip to content

Prefix the search icon to the keyboard shortcut#11274

Open
t-hamano wants to merge 6 commits intoWordPress:trunkfrom
t-hamano:64672-show-icon-on-desktop
Open

Prefix the search icon to the keyboard shortcut#11274
t-hamano wants to merge 6 commits intoWordPress:trunkfrom
t-hamano:64672-show-icon-on-desktop

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

Before

before

After

after

Trac ticket: https://core.trac.wordpress.org/ticket/64672

Use of AI Tools

None

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, sabernhardt, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional edit: setting the icon <span> to block display seems unnecessary on smaller screens because this PR removes display: none:

	#wpadminbar #wp-admin-bar-command-palette .ab-icon {
		display: block; /* Icon is only shown on mobile, while the keyboard shortcut is hidden */
	}

If that ruleset still helps, at least the comment needs updating (remove "only").

@t-hamano
Copy link
Copy Markdown
Contributor Author

Additional edit: setting the icon <span> to block display seems unnecessary on smaller screens because this PR removes display: none:

Nice catch, removed in 5252f64

Copy link
Copy Markdown
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot on a Mac:

Image

Appearance on different viewports:

Screen.Recording.2026-03-23.at.11.14.46.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants