Fix: Buttons output in `extra_tablenav` are too tall by hbhalodia · Pull Request #11224 · WordPress/wordpress-develop

hbhalodia · 2026-03-11T08:20:18Z

Trac ticket: https://core.trac.wordpress.org/ticket/64796

Before (button does not placed inside `.actions`)	After (button does not placed inside `.actions`)

Use of AI Tools

None

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2026-03-11T08:20:28Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hbhalodia, mukesh27, joedolson, nilambar, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-03-11T08:24:03Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

mukeshpanchal27

Thanks for the PR! Looks good to me.

ernilambar · 2026-03-13T18:21:23Z

Before	After

shail-mehta · 2026-03-20T18:12:48Z

Buttons rendered within extra_tablenav are displaying correctly. ✅

Before	After

joedolson

This fixes the specific named issue, but the same issue exists for other input types inserted in extra_tablenav, as well. E.g, adding a select or an input will also have the extra height.

I think the same logic should be used to ensure that other controls used by core in that context get the compact sizing. The select styling right above can be split between sizing characteristics & positioning characteristics.

I'm not sure that core uses an input in extra_tablenav anywhere, and it's more reasonable that extenders would need to style things not used by core, so it may not be necessary to add that.

hbhalodia · 2026-03-25T09:47:38Z

This fixes the specific named issue, but the same issue exists for other input types inserted in extra_tablenav, as well. E.g, adding a select or an input will also have the extra height.

I think the same logic should be used to ensure that other controls used by core in that context get the compact sizing. The select styling right above can be split between sizing characteristics & positioning characteristics.

I'm not sure that core uses an input in extra_tablenav anywhere, and it's more reasonable that extenders would need to style things not used by core, so it may not be necessary to add that.

Hi @joedolson, Thanks for the suggestion. I have updated to add all the input controls that can be used, but as rightly said, core does not uses all of them and its responsibility of extenders to fix the style if breaks at there end.

For now, I have update the PR to use it for all controls.

Thanks,

mukeshpanchal27 · 2026-03-25T12:11:09Z

src/wp-admin/css/forms.css

+.wp-core-ui .tablenav input[type="week"],
+.wp-core-ui .tablenav select {
+	padding: 0 12px;
+	/* inherits font size 14px */


Can you share why we need this comment?

It seems unnecessary, given that none of the other related contexts have a similar condition.

Changing my mind; it's helpful, as it gives context for the comment on the line-height calculation.

It comes from the same block of CSS in forms.css, which this duplicates, but adjusting to the compact sizing.

Thanks @joedolson @mukeshpanchal27, Yes I have kept it consistent from the original CSS forms.css.

joedolson

I think this is good as is; keeping the comment.

joedolson · 2026-03-25T21:06:10Z

src/wp-admin/css/forms.css

+.wp-core-ui .tablenav input[type="week"],
+.wp-core-ui .tablenav select {
+	padding: 0 12px;
+	/* inherits font size 14px */


It seems unnecessary, given that none of the other related contexts have a similar condition.

joedolson · 2026-03-25T21:06:37Z

src/wp-admin/css/forms.css

+.wp-core-ui .tablenav input[type="week"],
+.wp-core-ui .tablenav select {
+	padding: 0 12px;
+	/* inherits font size 14px */


Suggested change

/* inherits font size 14px */

joedolson · 2026-03-25T21:13:26Z

src/wp-admin/css/forms.css

+.wp-core-ui .tablenav input[type="week"],
+.wp-core-ui .tablenav select {
+	padding: 0 12px;
+	/* inherits font size 14px */


Changing my mind; it's helpful, as it gives context for the comment on the line-height calculation.

It comes from the same block of CSS in forms.css, which this duplicates, but adjusting to the compact sizing.

johnbillion

This fixes the issue in my plugin. Thanks.

github-actions · 2026-03-26T02:27:15Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62115
GitHub commit: 4d3b0b9

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

Fix issue for button height on extranav in custom list

aea235b

Merge branch 'trunk' into fix/issue-64796

c73cabb

mukeshpanchal27 approved these changes Mar 11, 2026

View reviewed changes

mukeshpanchal27 requested a review from johnbillion March 11, 2026 09:38

Merge branch 'trunk' into fix/issue-64796

4933132

johnbillion requested a review from fabiankaegy March 16, 2026 10:46

joedolson requested changes Mar 24, 2026

View reviewed changes

hbhalodia and others added 2 commits March 25, 2026 09:45

Merge branch 'trunk' into fix/issue-64796

5bf8645

Add other input types to match the 32px style

2828ed6

hbhalodia requested a review from joedolson March 25, 2026 09:47

mukeshpanchal27 reviewed Mar 25, 2026

View reviewed changes

joedolson approved these changes Mar 25, 2026

View reviewed changes

johnbillion approved these changes Mar 25, 2026

View reviewed changes

github-actions bot closed this Mar 26, 2026

Conversation

hbhalodia commented Mar 11, 2026

Use of AI Tools

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

ernilambar commented Mar 13, 2026

Uh oh!

shail-mehta commented Mar 20, 2026

Uh oh!

joedolson left a comment

Choose a reason for hiding this comment

Uh oh!

hbhalodia commented Mar 25, 2026

Uh oh!

mukeshpanchal27 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

joedolson Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

joedolson Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

hbhalodia Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

joedolson left a comment

Choose a reason for hiding this comment

Uh oh!

joedolson Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

joedolson Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

joedolson Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

johnbillion left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Mar 11, 2026 •

edited

Loading