Docs: update hook xrefs for relocated hooks#11203
Closed
apermo wants to merge 8 commits intoWordPress:trunkfrom
Closed
Docs: update hook xrefs for relocated hooks#11203apermo wants to merge 8 commits intoWordPress:trunkfrom
apermo wants to merge 8 commits intoWordPress:trunkfrom
Conversation
Update 5 cross-references for sidebar_admin_setup and delete_widget from `wp-admin/widgets.php` to `wp-admin/widgets-form.php` where the hooks now live. Related to https://core.trac.wordpress.org/ticket/64224
Update 5 cross-references for comment_feed_join, comment_feed_where, comment_feed_groupby, comment_feed_orderby, and comment_feed_limits from `query.php` to `class-wp-query.php`. Related to https://core.trac.wordpress.org/ticket/64224
Update 2 cross-references for process_text_diff_html from non-existent `wp-diff.php` to the actual file `class-wp-text-diff-renderer-table.php`. Related to https://core.trac.wordpress.org/ticket/64224
Update cross-reference for comment_flood_message from `comment-template.php` to `comment.php` where the hook's PHPDoc block now lives. Related to https://core.trac.wordpress.org/ticket/64224
Update cross-reference for ms_network_not_found from `ms-settings.php` to `ms-load.php` where the hook's PHPDoc block now lives. Related to https://core.trac.wordpress.org/ticket/64224
Update 2 cross-references for deprecated delete_blog and deleted_blog hooks from `ms-blogs.php` to `ms-site.php` where the hooks now live. Related to https://core.trac.wordpress.org/ticket/64224
Update 3 cross-references for image_save_progressive from `class-wp-image-editor-imagick.php` to `class-wp-image-editor-gd.php` where the filter's PHPDoc block is located. Related to https://core.trac.wordpress.org/ticket/64224
Update cross-reference for image_editor_output_format from `class-wp-image-editor.php` to `media.php` where the filter's PHPDoc block now lives (inside wp_get_image_editor_output_format). Related to https://core.trac.wordpress.org/ticket/64224
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
approved these changes
Mar 9, 2026
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Minor but great finding. Thanks @apermo
Member
|
Thanks for the PR! Merged in r61878. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 17 broken "This filter/action is documented in …" cross-reference comments where the hook was moved to a different file but the cross-reference was not updated:
wp-admin/widgets.php→wp-admin/widgets-form.php(sidebar_admin_setup,delete_widget) — 5 xrefswp-includes/query.php→wp-includes/class-wp-query.php(comment_feed_*filters) — 5 xrefswp-includes/wp-diff.php→wp-includes/class-wp-text-diff-renderer-table.php(process_text_diff_html) — 2 xrefswp-includes/comment-template.php→wp-includes/comment.php(comment_flood_message) — 1 xrefwp-includes/ms-settings.php→wp-includes/ms-load.php(ms_network_not_found) — 1 xrefwp-includes/ms-blogs.php→wp-includes/ms-site.php(delete_blog,deleted_blog) — 2 xrefswp-includes/class-wp-image-editor-imagick.php→wp-includes/class-wp-image-editor-gd.php(image_save_progressive) — 3 xrefs (core only; 3 additional in bundled Gutenberg)wp-includes/class-wp-image-editor.php→wp-includes/media.php(image_editor_output_format) — 1 xrefFor detailed investigation notes, see: https://github.com/apermo/wordpress-develop/milestone/2
Trac ticket: https://core.trac.wordpress.org/ticket/64224
Use of AI Tools
Research (cross-reference audit using custom PHPStan rules and PHP scripts) and code were produced by Claude Code (claude-sonnet-4-6). The contributor reviewed the findings, verified each fix, and approved the final implementation.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.