Skip to content

Editor: fix invalid patterns#11197

Closed
t-hamano wants to merge 5 commits intoWordPress:trunkfrom
t-hamano:64589-fix-broken-pattern
Closed

Editor: fix invalid patterns#11197
t-hamano wants to merge 5 commits intoWordPress:trunkfrom
t-hamano:64589-fix-broken-pattern

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano commented Mar 7, 2026 •
edited
Loading

Trac ticket: https://core.trac.wordpress.org/ticket/64589

Follow-up to https://core.trac.wordpress.org/changeset/61609

Use of AI Tools

None

Description

This PR fixes the following two invalid patterns:

Testing Instructions

  • Activate Twenty Twnty-Five
  • Go to Appearance > Editor > Global Styles > Styles
  • Choose the dark theme "Evening"
  • Go to Design > Patterns
  • Click the "Add Pattern" button and select "Add Template Part"
  • Select the "Navigation Overlay" area and create a template part

Navigation Overlay

Before After
image image

Overlay with site info and CTA

Before After
image image

@t-hamano t-hamano force-pushed the 64589-fix-broken-pattern branch from cd3eba5 to 669c609 Compare March 7, 2026 06:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

westonruter
westonruter reviewed Mar 13, 2026
View reviewed changes
t-hamano and others added 2 commits March 13, 2026 18:45
@t-hamano t-hamano marked this pull request as ready for review March 13, 2026 09:45
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, westonruter, onemaggie, mikachan, isabel_brison.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

MaggieCabrera
MaggieCabrera approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I am not a core committer so I can't help get it in

mikachan
mikachan approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes also look good to me, thanks @t-hamano!

tellthemachines
tellthemachines approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Code LGTM and works as expected in testing.

@tellthemachines tellthemachines added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 26, 2026
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 26, 2026
@t-hamano
Copy link
Copy Markdown
Contributor Author

t-hamano commented Mar 26, 2026

Thanks for the review!

@t-hamano
Copy link
Copy Markdown
Contributor Author

t-hamano commented Mar 26, 2026

This PR was committed by r62114.

@t-hamano t-hamano closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter left review comments

@mikachan mikachan mikachan approved these changes

@tellthemachines tellthemachines tellthemachines approved these changes

+1 more reviewer

@MaggieCabrera MaggieCabrera MaggieCabrera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@t-hamano @westonruter @mikachan @MaggieCabrera @tellthemachines