Skip to content

Apply background colour to welcome panel content.#11105

Closed
peterwilsoncc wants to merge 1 commit intoWordPress:trunkfrom
peterwilsoncc:fix/64741-welcome-panel-background
Closed

Apply background colour to welcome panel content.#11105
peterwilsoncc wants to merge 1 commit intoWordPress:trunkfrom
peterwilsoncc:fix/64741-welcome-panel-background

Conversation

@peterwilsoncc
Copy link
Copy Markdown
Contributor

@peterwilsoncc peterwilsoncc commented Mar 2, 2026

Reinstates the almost black background to the welcome panel's background image on wide screens.

Trac ticket: https://core.trac.wordpress.org/ticket/64741

  1. Set screen width to around 1700px
  2. On trunk the background image will have grey stripes next to it.
  3. On this branch it will not.

Use of AI Tools

N/A


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@peterwilsoncc peterwilsoncc requested a review from joedolson March 2, 2026 00:29
@peterwilsoncc peterwilsoncc marked this pull request as ready for review March 2, 2026 00:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, ramonopoly, huzaifaalmesbah, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@peterwilsoncc peterwilsoncc force-pushed the fix/64741-welcome-panel-background branch from 573305f to 78fb8f2 Compare March 2, 2026 00:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@huzaifaalmesbah
Copy link
Copy Markdown
Member

1920px without PR:
Huzaifa-20260302093210

1920px with PR:
Huzaifa-20260302093345

2560px with PR:
Huzaifa-20260302093409

Copy link
Copy Markdown
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It preserves the border color introduced in #11065

Image

@shail-mehta
Copy link
Copy Markdown
Member

The background color is now displaying correctly on wider screens.

Before After
before-patch after-patch

@peterwilsoncc peterwilsoncc force-pushed the fix/64741-welcome-panel-background branch from 78fb8f2 to 3bb2767 Compare March 2, 2026 21:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61798
GitHub commit: dc4071b

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 3, 2026
@peterwilsoncc peterwilsoncc deleted the fix/64741-welcome-panel-background branch March 3, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants