Skip to content

media frame anchor color variable used#11091

Closed
hmbashar wants to merge 4 commits intoWordPress:trunkfrom
hmbashar:media-modal
Closed

media frame anchor color variable used#11091
hmbashar wants to merge 4 commits intoWordPress:trunkfrom
hmbashar:media-modal

Conversation

@hmbashar
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 28, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hmbashar, audrasjb, mukesh27, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

.media-frame a:hover,
.media-frame a:active {
color: #135e96;
color: var(--wp-admin-theme-color, #3858e9);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same hover color? I see somewhere it use var(--wp-admin-theme-color-darker-20) for hover color.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find the hover color variable, and I noticed that there was a hardcoded color code. That's why I made the change—so when the reviewer sees the updates, they can easily change it to the correct variable if they know what it is. I thought that would be a good approach.

@audrasjb
Copy link
Copy Markdown
Contributor

Hello there, I performed a final review and I think the following items need to be addressed:

  1. Use the new color scheme for the information icon
  2. Use the compact size for inputs so the button is the same size than the text inputs
Capture d’écran 2026-03-12 à 07 40 18

For (2), alternatively we can just put the button on a new line, just like in the Crop section:

Capture d’écran 2026-03-12 à 07 40 41

Copy link
Copy Markdown
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes request, see comments

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@audrasjb
Copy link
Copy Markdown
Contributor

Looks good to me, now. Approved.
Uploading screencapture-playground-wordpress-net-2026-03-24-07_10_01.png…

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62098
GitHub commit: 8bf48cf

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants