External Libraries: Update the Requests library to version 2.0.17.#11082
Closed
rodrigoprimo wants to merge 1 commit intoWordPress:trunkfrom
Closed
External Libraries: Update the Requests library to version 2.0.17.#11082rodrigoprimo wants to merge 1 commit intoWordPress:trunkfrom
rodrigoprimo wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The most notable changes are PHP 8.5 compatibility fixes in version 2.0.16. Other releases between 2.0.11 and 2.0.17 contain only certificate bundle updates, which are skipped as WordPress manages its own certificate bundle (see #62812). I basically downloaded the Requests package from GitHub and manually copied its contents to `src/wp-includes/Requests`, ignoring the `library/` directory, which appears to have been modified by WP Core to handle backward compatibility differently from upstream. I'm not sure if there is a better way to handle the Requests update. While doing it, I also had to manually ensure that the `__wakeup()` methods in `Hooks.php`, `Iri.php`, and `Session.php` added in https://core.trac.wordpress.org/changeset/56835 as security hardening are preserved in this update (related upstream ticket: WordPress/Requests#949). References: - [Requests 2.0.12 release notes](https://github.com/WordPress/Requests/releases/tag/v2.0.12) - [Requests 2.0.13 release notes](https://github.com/WordPress/Requests/releases/tag/v2.0.13) - [Requests 2.0.14 release notes](https://github.com/WordPress/Requests/releases/tag/v2.0.14) - [Requests 2.0.15 release notes](https://github.com/WordPress/Requests/releases/tag/v2.0.15) - [Requests 2.0.16 release notes](https://github.com/WordPress/Requests/releases/tag/v2.0.16) - [Requests 2.0.17 release notes](https://github.com/WordPress/Requests/releases/tag/v2.0.17) - [Full list of changes since 2.0.11](WordPress/Requests@v2.0.11...v2.0.17)
rodrigoprimo
force-pushed
the
update-requests
branch
from
cce4ae7 to
dcb50e0
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most notable changes are PHP 8.5 compatibility fixes in version 2.0.16. Other releases between 2.0.11 and 2.0.17 contain only certificate bundle updates, which are skipped as WordPress manages its own certificate bundle (see #62812).
I basically downloaded the Requests package from GitHub and manually copied its contents to
src/wp-includes/Requests, ignoring thelibrary/directory, which appears to have been modified by WP Core to handle backward compatibility differently from upstream. I'm not sure if there is a better way to handle the Requests update. While doing it, I also had to manually ensure that the__wakeup()methods inHooks.php,Iri.php, andSession.phpadded in https://core.trac.wordpress.org/changeset/56835 as security hardening are preserved in this update (related upstream ticket: WordPress/Requests#949).References:
Trac ticket: https://core.trac.wordpress.org/ticket/64752
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.