Skip to content

[Admin reskin] Add background color to notice in login#11027

Closed
juanfra wants to merge 1 commit intoWordPress:trunkfrom
juanfra:fix/64715-notice-bg-color
Closed

[Admin reskin] Add background color to notice in login#11027
juanfra wants to merge 1 commit intoWordPress:trunkfrom
juanfra:fix/64715-notice-bg-color

Conversation

@juanfra
Copy link
Copy Markdown
Member

@juanfra juanfra commented Feb 24, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64715

Adding background color to the .notice in the login.css file, as the notices there don't match the reskin (complete styles live in common.css).

Before After
register-notice-before register-notice-after

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 24, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props juanfra, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@shail-mehta
Copy link
Copy Markdown
Member

Before After
before-patch after-patch

Copy link
Copy Markdown
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61731
GitHub commit: 8841bf1

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 25, 2026
@juanfra juanfra deleted the fix/64715-notice-bg-color branch February 25, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants