Update all references to the Verse block to Poetry#10969
Update all references to the Verse block to Poetry#10969jihaisse wants to merge 19 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Undo any changes to the To avoid confusion, I recommend editing "Verse" to "Poetry (Verse)" in the comments. Also, please update your fork. It still contains IE styles for Twenty Twenty-One, which were removed in r61628. |
|
Thanks @sabernhardt for your hints. I have reverted all class names and the sass folder. I have edited "Verse" to "Poetry (Verse)" in the comments. And finaly, the fork is up to date. Let me know if I missed something. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Not affect any style as it's docblock changes
|
Could you restore the branch and reopen the pull request? It was not committed. |
|
Sorry for the mess ! |
I've updated all references in all themes.
I've replace the
Verseblock name in comments and changewp-block-versetowp-block-poetryclass.In
twentytwentyonethere was a need to change the name of a folder, then change the imports and then make a build. I hope I did these well, if not, let me know where I was wrong.Trac ticket: https://core.trac.wordpress.org/ticket/64658
Use of AI Tools
None used.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.