Skip to content

[#47051] Twenty Nineteen theme sub-menu returns error in WAVE accessibility tool#10816

Open
VladimirAus wants to merge 12 commits intoWordPress:trunkfrom
VladimirAus:ticket/47051
Open

[#47051] Twenty Nineteen theme sub-menu returns error in WAVE accessibility tool#10816
VladimirAus wants to merge 12 commits intoWordPress:trunkfrom
VladimirAus:ticket/47051

Conversation

@VladimirAus
Copy link
Copy Markdown

@VladimirAus VladimirAus commented Jan 29, 2026

The goal for a core patch isn't just to satisfy WAVE, but to ensure that screen reader users (who might be navigating a complex menu) understand exactly what these buttons do.

Corrected logic for twentynineteen_add_dropdown_icons. I have added aria-label to both the "Return" button and the "Expand" button.

Ticket: https://core.trac.wordpress.org/ticket/47051

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props vladimiraus, joedolson, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@VladimirAus
Copy link
Copy Markdown
Author

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@VladimirAus VladimirAus changed the title Ticket/47051 [#47051] Twenty Nineteen theme sub-menu returns error in WAVE accessibility tool Jan 29, 2026
Copy link
Copy Markdown

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translatable strings would need translator comments to describe the menu item name.

joedolson and others added 3 commits February 25, 2026 14:25
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Copy link
Copy Markdown
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this is now sufficient for resolving the specific issues raised in the ticket.

@joedolson joedolson self-requested a review February 26, 2026 00:03
@joedolson
Copy link
Copy Markdown
Contributor

Unfortunately, after looking further, I don't see any benefit to committing this change, due to the nature of the other problems in the menu. Ultimately, this wouldn't have any actual benefits for accessibility - the other problems would prevent this from being helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants