Block support: Add server-side processing for anchor#10655

Closed

t-hamano wants to merge 29 commits intoWordPress:trunkfrom

t-hamano:64449-dynamic-anchor-block-support

Contributor

t-hamano commented Dec 23, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/64449

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.


          Block support: Add server-side processing for anchor

5beef85

github-actions bot commented Dec 23, 2025 •

edited

Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions bot commented Dec 23, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions bot mentioned this pull request

PHP backports for WP 7.0 WordPress/gutenberg#74043

Open

t-hamano added 2 commits

December 25, 2025 18:47


          Update logic and unit test cases

1c412fb


          Fix PHP syntax error

f6608ad

westonruter reviewed

View reviewed changes

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

t-hamano and others added 2 commits

January 2, 2026 22:45


          Update PHPDoc

13d2093

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Added types to arguments of wp_apply_anchor_support function

2fc8202

Co-authored-by: Weston Ruter <westonruter@gmail.com>

westonruter reviewed

View reviewed changes

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

westonruter reviewed

View reviewed changes

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

westonruter reviewed

View reviewed changes

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

westonruter reviewed

View reviewed changes

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

t-hamano and others added 3 commits

January 3, 2026 18:17


          Update types to arguments of wp_apply_anchor_support function

5dd82bf

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Improve code quality

8c0ec1b

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Improve code quality

77607d7

Co-authored-by: Weston Ruter <westonruter@gmail.com>

westonruter requested changes

View reviewed changes

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

tests/phpunit/tests/block-supports/anchor.php Outdated Show resolved Hide resolved

tests/phpunit/tests/block-supports/anchor.php Outdated Show resolved Hide resolved

tests/phpunit/tests/block-supports/anchor.php Outdated Show resolved Hide resolved

tests/phpunit/tests/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

t-hamano and others added 13 commits

January 4, 2026 18:40


          Fix how $block_attributes is checked

fe41b68

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Add type to argument

6a6e988

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Simplify method for checking block support

583d2fb

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Add type to return value

ea0f9a2

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Simplify method for checking block support

3f5d42a

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Fix test file name

354c792


          Add type to return value

4bd969a

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Add type to argument

1a7c7e8

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Remove unnecessary blank line in PHPDoc

c158c96

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Making block name constant

e41417c

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          block name no longer needs to be null

1f615a9

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          block name no longer needs to be null

58c77b7

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Remove unnecessary argument from register_anchor_block_with_support f…

3510f6a

…unction

Co-authored-by: Weston Ruter <westonruter@gmail.com>

t-hamano and others added 6 commits

January 4, 2026 18:53


          Remove unnecessary argument from register_anchor_block_with_support f…

78c500b

…unction

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Fix param types

7afac3b

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Add unit test for wp_register_anchor_support()

8fee9e1


          Code format

44b319b


          Fix invalid code

a077d66


          Improve types in Tests_Block_Supports_Anchor for PHPStan level 8

27ff1f8

westonruter approved these changes

View reviewed changes

Member

westonruter left a comment

This looks good to me. A couple other tiny nits/suggestions which aren't necessary for merge.

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

src/wp-includes/block-supports/anchor.php Outdated Show resolved Hide resolved

t-hamano and others added 2 commits

January 5, 2026 14:48


          check attributes more strictly

bcb1762

Co-authored-by: Weston Ruter <westonruter@gmail.com>


          Merge two conditional statements

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Contributor Author

t-hamano commented Jan 5, 2026

@westonruter Thanks for the review! I'll commit this change later.

github-actions bot commented Jan 5, 2026

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61437
GitHub commit: adc9daf

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

github-actions bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet