Add an exclusion to prevent building full-page of interactivity-router #10396
Conversation
The full-page wpScriptModuleExport defined in interactivity-router should not be bundled in Wordpress core yet as it is experimental. There is no mechanism in wpScriptModuleExports right now that supports building a script module but not including it in core. Since this is likely to be a rare instance we have opted to hard-code an exclusion in core's build until this module is no longer experimental.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Confirmed that this one script module is excluded.
5 participants
The full-page wpScriptModuleExport defined in interactivity-router should not be bundled in WordPress core yet as it is experimental. There is no mechanism in wpScriptModuleExports right now that supports building a script module but not including it in core. Since this is likely to be a rare instance we have opted to hard-code an exclusion in core's build until this module is no longer experimental.
Trac ticket: https://core.trac.wordpress.org/ticket/64137
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.