Update README to include forking instructions before cloning repository#10286
Update README to include forking instructions before cloning repository#10286pbearne wants to merge 9 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
desrosj
left a comment
desrosj
left a comment
There was a problem hiding this comment.
I'm thinking that this would be better off as a numbered list of steps. Let's make the following changes:
- Add an intro sentence. "You can get started using the local development environment with these steps:"
- Where to go
- Click create fork
- Clone forked repo.
- Configure
upstreamorigin - How to keep your branches up to date.
After that, a include the "Alternatively" sentence.
And finally "After either if the two options above, move to the..."
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Updated instructions for forking and cloning the repository with numbered steps for clarity.
desrosj
left a comment
desrosj
left a comment
There was a problem hiding this comment.
Few more small suggestions. I think it's good to go after those, though. I will commit tomorrow unless there are any objections.
|
|
||
| After either of the two options above, move to the repository folder `cd wordpress-develop` and run the following commands in a terminal: |
There was a problem hiding this comment.
| After either of the two options above, move to the repository folder `cd wordpress-develop` and run the following commands in a terminal: |
Co-authored-by: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com>
|
This looks good to me for the purpose of clarifying to create a fork. While editing the file, should the code spaces reference be removed as they haven't worked for a while. See https://core.trac.wordpress.org/ticket/57896 
|
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
That makes sense, I think. It would be great to get that fixed, but preventing frustration for anyone attempting to use that as a means to contribute is probably best in the mean time. I'll remove that section when committing. |
desrosj
added
the
props-bot
github-actions
bot
removed
the
props-bot
5 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64100