Skip to content

Integrate sticky posts with Post Type Support API #48954#10220

Open
igorradovanov wants to merge 3 commits intoWordPress:trunkfrom
igorradovanov:#48954
Open

Integrate sticky posts with Post Type Support API #48954#10220
igorradovanov wants to merge 3 commits intoWordPress:trunkfrom
igorradovanov:#48954

Conversation

@igorradovanov
Copy link
Copy Markdown

Normalizes sticky post handling across WordPress by making stickiness a declared post type feature instead of hardcoded checks.

Core changes:
• Updated is_sticky(), stick_post(), unstick_post() to check post_type_supports()
• Added sticky support to 'post' type by default via add_post_type_support()
• Normalized UI checks in get_inline_data(), post_submit_meta_box(), XML-RPC

UI fixes:
get_inline_data(): Changed hierarchical check to post_type_supports()
post_submit_meta_box(): Replaced hardcoded 'post' checks with post_type_supports()
• XML-RPC: Updated post type checks to use post_type_supports()

Not discussed in Trac, but covered:
• Developers can add sticky support to custom post types via 'supports' => ['sticky']
• Prevents UI leakage of sticky status for unsupported post types
• Maintains backward compatibility for existing 'post' behavior
• Eliminates inconsistent sticky checks throughout WordPress core

Fixes #48954

Trac ticket: https://core.trac.wordpress.org/ticket/48954

Makes stickiness a declared post type feature checked via post_type_supports() instead of inconsistent hardcoded checks. Updates core sticky functions and  UI layers (get_inline_data, post_submit_meta_box, XML-RPC) to use unified
post type support checks. Enables custom post types to declare sticky support while maintaining backward compatibility.

Fixes #48954
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props igorradovanov.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

… expect sticky functions to work with non-existent post IDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant