Skip to content

Remove Pullquote block from theme twenty nineteen#10202

Open
Utsav-Ladani wants to merge 4 commits intoWordPress:trunkfrom
Utsav-Ladani:deprecate/pullquote-block
Open

Remove Pullquote block from theme twenty nineteen#10202
Utsav-Ladani wants to merge 4 commits intoWordPress:trunkfrom
Utsav-Ladani:deprecate/pullquote-block

Conversation

@Utsav-Ladani
Copy link
Copy Markdown

Summary

The Pullquote block will be deprecated soon. Check this GitHub issue for more details: WordPress/gutenberg#11610

Hence, replacing Pullquote block across all themes with other similar blocks. This PR is changing following items:

  1. What We Do pattern of the twenty nineteen theme
  2. Highlighted Quote pattern of the twenty ten theme

Trac ticket: https://core.trac.wordpress.org/ticket/64068

Screenshots

Theme Pattern
What We Do pattern of the twenty nineteen theme What We Do pattern of the twenty nineteen theme
Highlighted Quote pattern of the twenty ten theme Highlighted Quote pattern of the twenty ten theme

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props utsavladani, sabernhardt, wildworks, ramonopoly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You went above and beyond, and I do not think it needs so much.

@Utsav-Ladani Utsav-Ladani force-pushed the deprecate/pullquote-block branch from 631ff61 to 10477fd Compare October 10, 2025 11:26
@t-hamano
Copy link
Copy Markdown
Contributor

@sabernhardt, We're almost ready to deprecate the Pullquote block, and I expect this Gutenberg PR to be merged soon.

WordPress/gutenberg#72028

If we deprecate the Pullquote block in the 6.9 release, would that have any impact on default themes? Would it be better to postpone the deprecation until 7.0?

Just to be clear, "deprecating a block" simply means that you can no longer insert the block; it doesn't mean that the block will break in your content or that styling will be broken on the front end.

@sabernhardt
Copy link
Copy Markdown

Would it be better to postpone the deprecation until 7.0?

It is quite late in the 6.9 cycle to deprecate a block, so delaying that should be good. The themes' patterns could be changed first, and then we can test all the default themes with releases of the Gutenberg plugin instead of applying pull requests. (Authors of other themes could need to test the deprecation with a plugin release too.)

So far, the only problem I know to resolve in default themes is these two patterns.

The themes' CSS should remain for anyone who already used the block (and could copy an existing Pullquote to paste it into a new post or widget). But when the Pullquote is deprecated, we would not need to edit the CSS further for several outstanding Trac tickets.

@t-hamano
Copy link
Copy Markdown
Contributor

@sabernhardt Thanks for the reply.

Well, just to be safe, let's NOT deprecate the Pullquote block in the 6.9 release.

@ramonjd
Copy link
Copy Markdown
Member

ramonjd commented Oct 13, 2025

The themes' patterns could be changed first, and then we can test all the default themes with releases of the Gutenberg plugin instead of applying pull requests.

Sounds like a good idea to get these changes in first. Thanks, folks!

Just a question - how close should the replacements be to the former designs?

Here's what I'm seeing

2019

Trunk This branch
Screenshot 2025-10-13 at 11 26 18 am Screenshot 2025-10-13 at 11 26 08 am

2010

Trunk This branch
Screenshot 2025-10-13 at 11 28 05 am Screenshot 2025-10-13 at 11 27 30 am

I'm thinking the italics in 2019 and extra padding in 2010 could align things a little better?

I don't have strong opinions on this to be clear, just asking 😄

@sabernhardt
Copy link
Copy Markdown

how close should the replacements be to the former designs?
I'm thinking the italics in 2019 and extra padding in 2010 could align things a little better?

For Twenty Nineteen, the current appearance of the Pullquote does not match images @kjellr shared on Trac 51099. The editor screenshots show all text in the serif (paragraph) font, without italics. The front end italicized the larger text and used a sans-serif for the smaller text. Since then, the first Pullquote became centered and the Cover block assigned white text with a light background. I think this is an opportunity to use more appropriate markup.

However, the Cover blocks' standard min-height of 430 is quite high and probably can be about half that (220 pixels equals 10rem).

					// Section 1: Redefine brands.
-					'<!-- wp:cover {"overlayColor":"primary","align":"wide"} -->',
-					'<div class="wp-block-cover alignwide has-primary-background-color has-background-dim"><div class="wp-block-cover__inner-container"><!-- wp:heading {"level":3,"textColor":"white"} -->',
+					'<!-- wp:cover {"overlayColor":"primary","minHeight":220,"align":"wide"} -->',
+					'<div class="wp-block-cover alignwide has-primary-background-color has-background-dim" style="min-height:220px"><div class="wp-block-cover__inner-container"><!-- wp:heading {"level":3,"textColor":"white"} -->',

Twenty Ten's Quote block should have more padding. The theme stylesheet defines blockquote {padding:0 3em} and block-library/theme.css overrides the left side with 1em when the block combines the classes for both Large and Plain styles (is-style-large is-style-plain). The Pullquote has the 0 3em padding and a max-width of 60%, inside a Cover block with 1em padding, which makes the text elements only 364.8 pixels wide in the 640-pixel post content area.

Considering that the Large style was deprecated in 6.0, the classes could be changed to is-style-plain highlighted-quote. That would keep the Plain style, and the padding would be even with 3em on both sides. With a special highlighted-quote class, the CSS could define the exact styles desired for the pattern. Then the font size could increase to 2em:

.wp-block-quote.highlighted-quote p {
	font-size: 2em;
	line-height: 1.3;
}

@ramonjd
Copy link
Copy Markdown
Member

ramonjd commented Oct 13, 2025

Thanks for the explainer @sabernhardt

For Twenty Nineteen, the current appearance of the Pullquote does not match images @kjellr shared on Trac 51099.

Thanks for leading me there. 🙇🏻

@Utsav-Ladani
Copy link
Copy Markdown
Author

Utsav-Ladani commented Oct 14, 2025

Thanks for the detailed explanation. I made changes accordingly. Here's preview of these changes:
Screenshot 2025-10-14 at 2 09 48 PM

Screenshot 2025-10-14 at 2 08 56 PM

@Utsav-Ladani
Copy link
Copy Markdown
Author

@sabernhardt Let me know if this requires further changes.

@t-hamano
Copy link
Copy Markdown
Contributor

Update: We just officially deprecated the Pullquote block: WordPress/gutenberg#73228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants