Remove Pullquote block from theme twenty nineteen#10202
Remove Pullquote block from theme twenty nineteen#10202Utsav-Ladani wants to merge 4 commits intoWordPress:trunkfrom
Pullquote block from theme twenty nineteen#10202Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sabernhardt
left a comment
There was a problem hiding this comment.
You went above and beyond, and I do not think it needs so much.
631ff61 to
10477fd
Compare
|
@sabernhardt, We're almost ready to deprecate the Pullquote block, and I expect this Gutenberg PR to be merged soon. If we deprecate the Pullquote block in the 6.9 release, would that have any impact on default themes? Would it be better to postpone the deprecation until 7.0? Just to be clear, "deprecating a block" simply means that you can no longer insert the block; it doesn't mean that the block will break in your content or that styling will be broken on the front end. |
It is quite late in the 6.9 cycle to deprecate a block, so delaying that should be good. The themes' patterns could be changed first, and then we can test all the default themes with releases of the Gutenberg plugin instead of applying pull requests. (Authors of other themes could need to test the deprecation with a plugin release too.) So far, the only problem I know to resolve in default themes is these two patterns. The themes' CSS should remain for anyone who already used the block (and could copy an existing Pullquote to paste it into a new post or widget). But when the Pullquote is deprecated, we would not need to edit the CSS further for several outstanding Trac tickets. |
|
@sabernhardt Thanks for the reply. Well, just to be safe, let's NOT deprecate the Pullquote block in the 6.9 release. |
For Twenty Nineteen, the current appearance of the Pullquote does not match images @kjellr shared on Trac 51099. The editor screenshots show all text in the serif (paragraph) font, without italics. The front end italicized the larger text and used a sans-serif for the smaller text. Since then, the first Pullquote became centered and the Cover block assigned white text with a light background. I think this is an opportunity to use more appropriate markup. However, the Cover blocks' standard // Section 1: Redefine brands.
- '<!-- wp:cover {"overlayColor":"primary","align":"wide"} -->',
- '<div class="wp-block-cover alignwide has-primary-background-color has-background-dim"><div class="wp-block-cover__inner-container"><!-- wp:heading {"level":3,"textColor":"white"} -->',
+ '<!-- wp:cover {"overlayColor":"primary","minHeight":220,"align":"wide"} -->',
+ '<div class="wp-block-cover alignwide has-primary-background-color has-background-dim" style="min-height:220px"><div class="wp-block-cover__inner-container"><!-- wp:heading {"level":3,"textColor":"white"} -->',Twenty Ten's Quote block should have more padding. The theme stylesheet defines Considering that the Large style was deprecated in 6.0, the classes could be changed to |
|
Thanks for the explainer @sabernhardt
Thanks for leading me there. 🙇🏻 |
|
@sabernhardt Let me know if this requires further changes. |
|
Update: We just officially deprecated the Pullquote block: WordPress/gutenberg#73228 |






Summary
The
Pullquoteblock will be deprecated soon. Check this GitHub issue for more details: WordPress/gutenberg#11610Hence, replacing
Pullquoteblock across all themes with other similar blocks. This PR is changing following items:What We Dopattern of the twenty nineteen themeHighlighted Quotepattern of the twenty ten themeTrac ticket: https://core.trac.wordpress.org/ticket/64068
Screenshots
What We Dopattern of the twenty nineteen themeHighlighted Quotepattern of the twenty ten themeThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.