Focus in code input when totp is checked#645
Merged
kasparsd merged 2 commits intoWordPress:masterfrom Dec 2, 2024
Merged
Conversation
kasparsd
approved these changes
Dec 2, 2024
Collaborator
kasparsd
left a comment
kasparsd
left a comment
There was a problem hiding this comment.
This looks good! Can switch to jQuery for consistency with the rest of the inline JS in a follow-up pull request.
Also, need to ensure that this JS doesn't fail if the TOTP method is not available (disabled via code, for example).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the UX for when TOTP is checked it focuses in the code input, fixes #159
Why?
For better UX as requested in #159
How?
Adds an event listener to check when the checkbox is enabled to focus into the code.
Testing Instructions
Start the env after checking out into the branch go to http://localhost:8888/wp-admin/profile.php, scroll down two factor options, confirm it focuses into the input.
Screenshots or screencast
https://share.cleanshot.com/qWNlb6gQTp90hDS8Fq0Q
Changelog Entry