Fixing bug where Super Admins cannot setup Time Based One-Time Password as first Two Factor option on WP VIP#560
Merged
dd32 merged 2 commits intoWordPress:masterfrom May 2, 2023
Merged
Conversation
current_user_can() expects user_id to be integer Fixes WordPress#559 Fixes WordPress#557
…stead of number to make consistent with Two_Factor_Totp
dd32
added
Bug
TOTP
|
I was just about to report this bug, based on an experience I'm having with a VIP Go site. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixing bug where WP VIP Super Admins and WooCommerce shop_manager cannot setup Time Based One-Time Password as their first Two Factor option. Please have a look at #559 for more detailed information.
Why
Fixes #559
Fixes #557
How?
I am setting the controller parameter configuration to have user_id as an integer instead of a number because strict comparison requires matching types.
Steps to Test
wp-admin>Edit ProfileChangelog Entry
Fixing bug where WP VIP Super Admins and WooCommerce shop_manager cannot setup Time Based One-Time Password as their first Two Factor option
Notes
Original PR: Automattic/vip-go-mu-plugins#4410