Repository navigation
Commit a766c19
Keep the unbounded failure reason out of the error log by default
'expired' and 'mismatch' both require a nonce to already be stored for the
user, which only happens after a successful password check, so their volume
is bounded by real login activity.
'no_nonce_stored' is not bounded. Any unauthenticated request carrying a
guessed user ID reaches it, so logging it by default would hand anyone an
unthrottled write to the error log. It is also the least informative of the
three, firing for every stale bookmark and resubmitted form.
The action still fires for all three, so anything routing these into an
audit log or intrusion detection system is unaffected, and sites that want
'no_nonce_stored' in the error log can opt in through the filter.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent fdbfdb9 commit a766c19
2 files changed
Lines changed: 59 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1432 | 1432 | | |
1433 | 1433 | | |
1434 | 1434 | | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
1435 | 1447 | | |
1436 | | - | |
| 1448 | + | |
1437 | 1449 | | |
1438 | | - | |
1439 | | - | |
1440 | | - | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
1441 | 1453 | | |
1442 | 1454 | | |
1443 | 1455 | | |
1444 | | - | |
| 1456 | + | |
1445 | 1457 | | |
1446 | 1458 | | |
1447 | 1459 | | |
1448 | | - | |
| 1460 | + | |
1449 | 1461 | | |
1450 | 1462 | | |
1451 | 1463 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
779 | 779 | | |
780 | 780 | | |
781 | 781 | | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
782 | 788 | | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
783 | 792 | | |
784 | | - | |
| 793 | + | |
785 | 794 | | |
786 | 795 | | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
787 | 809 | | |
788 | | - | |
789 | | - | |
| 810 | + | |
| 811 | + | |
790 | 812 | | |
791 | 813 | | |
792 | 814 | | |
| |||
795 | 817 | | |
796 | 818 | | |
797 | 819 | | |
798 | | - | |
| 820 | + | |
799 | 821 | | |
800 | 822 | | |
801 | 823 | | |
802 | 824 | | |
803 | 825 | | |
804 | | - | |
| 826 | + | |
805 | 827 | | |
806 | | - | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
807 | 842 | | |
808 | 843 | | |
809 | 844 | | |
| |||
0 commit comments