This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Having an h1 on single posts #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single.html template doesn't have an h1 that should be the post title.
kjellr
changed the title
kjellr
changed the title
Collaborator
|
Since the Site Title is a H1, implementing this (or #250) would unfortunately break compliance with the accessibility guidelines for themes. Let's continue to discuss in #233. |
Collaborator
|
As per the discussion in #233 (comment), we should be ok using more than one H1 per page. I've updated the "No Separators" template too, and will merge this in. Thanks for the help, @SGr33n! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single.html template doesn't have an h1 that should be the post title.