Fixed Pulloquote Block border issue#550
Conversation
theme.json
Outdated
| "bottom": { | ||
| "style": "none", | ||
| "width": "0px" | ||
| "style": "solid", |
There was a problem hiding this comment.
In order to make the borders work again and keep the layout as in the design, the bottom, left, right and top attributes should be completely removed. This way there's no border when using the block as default, and borders can be added if the block settings are updated.
Please remove the mentioned attributes, but keep the radius attribute.
There was a problem hiding this comment.
Hello @luminuu
I have added my new PR.
Please review it and let me know your feedback for the same.
Thanks,
theme.json
Outdated
| "style": "none", | ||
| "width": "0px" | ||
| } | ||
| "style": "solid", |
There was a problem hiding this comment.
This does not need to be added, as the default design of the pullquote block does not have a border. Please remove these two lines.
There was a problem hiding this comment.
theme.json
Outdated
| "style": "none", | ||
| "width": "0px" | ||
| } | ||
| "style": "solid" |
There was a problem hiding this comment.
Please remove the "style": "solid" too, as it creates a border that is not in the design:
There was a problem hiding this comment.
luminuu
left a comment
luminuu
left a comment
There was a problem hiding this comment.
Tested. By default, the pullquote has no border as intended in the design, and borders can be added via the block settings if needed.
2 participants
Description
Hello Team,
I have worked on issue #533 and resolved it from my end. Here, I have added my PR.
Screenshots
Back-end
Front-end
Testing Instructions
Contributors