Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Correct theme var references for font-size - #97

Closed
g-elwell wants to merge 1 commit into
WordPress:trunkfrom
g-elwell:fix/correct-theme-var-references
Closed

g-elwell wants to merge 1 commit into
WordPress:trunkfrom
g-elwell:fix/correct-theme-var-references

Conversation

@g-elwell

Copy link
Copy Markdown
Contributor

Description

This PR updates the references to the font size theme variable to correctly use kebab-case instead of camelCase. This change is required to correctly reference CSS custom properties generated by the theme.

Screenshots

Before:
image

After:
image

Testing Instructions

  1. Insert one of the styled blocks (either site title, site tagline or navigation)
  2. Inspect the CSS to check whether the font size referenced in theme.json is being applied

@github-actions

github-actions Bot commented Aug 20, 2024 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @g-elwell.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: g-elwell.

Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: rejaulalomkhan <rejaulalomkhan@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@huzaifaalmesbah

Copy link
Copy Markdown
Member

Good catch. Thanks @g-elwell For the PR.

@rejaulalomkhan

Copy link
Copy Markdown
Contributor

Thanks for the PR @g-elwell, It's work for me.

Before Applying PR After Applying PR
image image

@carolinan

Copy link
Copy Markdown
Contributor

Thank you, I believe this was fixed in #93.

@g-elwell

Copy link
Copy Markdown
Contributor Author

Thank you, I believe this was fixed in #93.

Excellent, will close this one then

@g-elwell g-elwell closed this Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants