Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Block Pattern: Contact - Centered link and social links#96

Merged
carolinan merged 8 commits intoWordPress:trunkfrom
kishanjasani:pattern/contact-centered-social-link
Aug 23, 2024
Merged

Block Pattern: Contact - Centered link and social links#96
carolinan merged 8 commits intoWordPress:trunkfrom
kishanjasani:pattern/contact-centered-social-link

Conversation

@kishanjasani
Copy link
Copy Markdown
Contributor

Description
Adding the Contact with centered link and social link block pattern.

Closes #60

Screenshots
https://prnt.sc/aBysxxXPeKcb

Testing Instructions

  1. Apply the PR.
  2. Add page or posts and Click on Block Inserter.
  3. Go to pattern section and click on contact block pattern: https://prnt.sc/MjvfRD63R5GQ

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kishanjasani <kishanjasani@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: rejaulalomkhan <rejaulalomkhan@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown
Member

@huzaifaalmesbah huzaifaalmesbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kishanjasani for the PR. We need to make some changes. Please remove this code: "iconColorValue":"#111111", and also add the social icon URL #.

@rejaulalomkhan
Copy link
Copy Markdown
Contributor

Dear @kishanjasani, Thank you for moving forward to resolve the issue.
Based on Figma design PR design not matched. You should follow the Figma design.
Heading should be two line and 2nd line have underlined.

Figma Design PR Design
image image

@kishanjasani
Copy link
Copy Markdown
Contributor Author

kishanjasani commented Aug 21, 2024

Thanks @kishanjasani for the PR. We need to make some changes. Please remove this code: "iconColorValue":"#111111", and also add the social icon URL #.

Thank you for the suggestions @huzaifaalmesbah. I have updated the markup as per you suggestions.

Heading should be two line and 2nd line have underlined.

Thank you for the review @rejaulalomkhan.
https://prnt.sc/7oll01CxojEs I have added a link to add the underline as paragraph or heading block do not have underline option. Let me know your suggestions. To break it into the two line I have used <br>. Is it good idea?

@karmatosed karmatosed added the [Status] Needs Design Feedback Needs general design feedback. label Aug 21, 2024
@kishanjasani kishanjasani requested a review from carolinan August 22, 2024 17:14
@carolinan carolinan merged commit cbbdbd2 into WordPress:trunk Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Status] Needs Design Feedback Needs general design feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block Patterns - Contact - Centered link and social links

5 participants