Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@melchoyce
Copy link
Contributor

Description

The Book and Podcast landing page patterns were both missing an h1. I've updated the hero patterns to use h1 instead of h2.

Fixes #369.

Screenshots

No visual change.

Testing Instructions

  1. Ensure the theme is active
  2. Add a new page
  3. Select the Book or Podcast landing page patterns
  4. Ensure the hero pattern at the top is using an h1 instead of h2

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: melchoyce <melchoyce@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: rejaulalomkhan <rejaulalomkhan@git.wordpress.org>
Co-authored-by: ddewan-git <ddewan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@melchoyce melchoyce added [Component] Block Patterns Accessibility (a11y) Needs accessibility testing or feedback labels Sep 20, 2024
@rejaulalomkhan
Copy link
Contributor

Thank you @melchoyce for addressing this important accessibility issue! Ensuring that the hero patterns now use an h1 instead of h2 improves both the semantic structure and SEO of the landing pages. This is a subtle but impactful update that enhances the overall user experience, especially for screen readers and search engines. Great work on making this fix!

@carolinan carolinan merged commit 75c982e into trunk Sep 22, 2024
@juanfra juanfra deleted the update-pattern-headings branch September 23, 2024 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility (a11y) Needs accessibility testing or feedback [Component] Block Patterns

Projects

None yet

Development

Successfully merging this pull request may close these issues.

H1 missing in landing page patterns

4 participants