Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Fix featured images mobile#366

Merged
juanfra merged 2 commits intoWordPress:trunkfrom
dballari:fix-featured-images-mobile
Sep 19, 2024
Merged

Fix featured images mobile#366
juanfra merged 2 commits intoWordPress:trunkfrom
dballari:fix-featured-images-mobile

Conversation

@dballari
Copy link
Copy Markdown
Contributor

Description

This PR fixes issue #345
To solve it the constrained layout setting has been removed from the query loop, the group inside and the post content block

Screenshots

Screenshot from 2024-09-18 11-29-42
Screenshot from 2024-09-18 11-29-15
Screenshot from 2024-09-18 11-28-43

Testing Instructions

Got to all the templates that use the posts-personal-blog pattern, that is home index search and archive from the editor, switch to mobile view and verify the featured image has the right horizontal paddings. Then visit the web from the browser to make sure nothing has changed.

@github-actions
Copy link
Copy Markdown

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dballari <dballari@git.wordpress.org>
Co-authored-by: beafialho <beafialho@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@beafialho
Copy link
Copy Markdown
Contributor

Thank you @dballari, this seems to work as intended now!

Copy link
Copy Markdown
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@juanfra juanfra merged commit 9bd5fd9 into WordPress:trunk Sep 19, 2024
@dballari dballari deleted the fix-featured-images-mobile branch September 19, 2024 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants