This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Create CTA: grid with products and link pattern #68#273
Merged
juanfra merged 1 commit intoWordPress:trunkfrom Sep 24, 2024
Merged
Create CTA: grid with products and link pattern #68#273juanfra merged 1 commit intoWordPress:trunkfrom
juanfra merged 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Thank you @graylaurenm for working on this one! The layout on Desktop is looking great but unfortunately, the Grid block when set to "Manual" doesn't scale well. We may need to set it to "Auto" for it to be responsive. |
Contributor
Author
|
Hm, you're right, this code shows the grid as |
Contributor
|
@graylaurenm if you set the Grid to Auto and set it to This happens on mobile though:
So perhaps we want to use Cover with a square aspect ratio here. Everything else is looking good, although the images aren't showing up for me. |
juanfra
added
the
[Priority] High
Member
|
Thanks so much for working on this @graylaurenm Is there anything we can do to help you take this to the finish line? |
Contributor
|
Took a quick stab at seeing if I could fix this up. The only change I made to Lauren's work was to make the Grid block auto with a minimum width of 10rem. New patternHere's the result:
Note that the broken images in the editor, I'm not sure why they happen. It's probably local to my env. The main take-away is what Bea already mentioned, the collapsing cells. Adding a square Cover block for those colored pieces both adds a nice little text-prompt if you want to add text in those cells in the editor, but it fixes the issue: New codeLet me see if I can help this PR along, unless you object! |
Contributor
|
Created #390 as an alternative, as I was not able to push to this branch. But credit on that new branch should still go to Lauren! Thanks for contributing, and let me know if that other branch works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request houses work on the pattern tracked in issue #68
Screenshots
These are of the initial, incomplete version.
Testing Instructions
Insert this block into any page.