Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Add: Events – List with Call to Action#182

Merged
carolinan merged 5 commits intoWordPress:trunkfrom
graylaurenm:events-with-cta
Sep 10, 2024
Merged

Add: Events – List with Call to Action#182
carolinan merged 5 commits intoWordPress:trunkfrom
graylaurenm:events-with-cta

Conversation

@graylaurenm
Copy link
Copy Markdown
Contributor

Description

Adds "Block Patterns - Events - List of events with call to action" #83

Screenshots

Screen.Recording.at.2024-09-02.at.12-15-54.webm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: graylaurenm <oncecoupled@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Sep 6, 2024

Hi!
I think the block needs a full width wrapper so that it matches the width and behavior of other patterns when the user adds a background color. Here is a comparison to one of the other patterns with background color added:

image


All heading levels are the same, the main heading, "Upcoming events" should be one level higher than the others.
You can increase its level, or decrease the level of the event names.

"Upcoming events" should be larger. In Figma 48px is used.


There needs to be an empty blank line at the end of the file.

@graylaurenm
Copy link
Copy Markdown
Contributor Author

Thank you for this review, Carolina. I have:

  1. added the full-width wrapper
  2. fixed the incorrect h3 to an h2
  3. added the blank line to the end of the file

@carolinan
Copy link
Copy Markdown
Contributor

Hi, I have one small nit, the references to is-style-default can be removed,

@carolinan
Copy link
Copy Markdown
Contributor

Thank you!

@carolinan carolinan merged commit e52e749 into WordPress:trunk Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block Patterns - Events - List of events with call to action

3 participants