Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Add the 70px font size as a custom CSS property in theme.json #173

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Add the 70px font size as a custom CSS property in theme.json #173

merged 3 commits into from
Sep 2, 2024

Conversation

@kishanjasani
Copy link
Contributor

@kishanjasani kishanjasani commented Sep 2, 2024 •
edited
Loading

Description
Adds custom font size as a custom CSS property. Closes: #170

Testing Instructions

  1. After Activate theme, Go to any post or page
  2. RIght click on page and open Inspect element.
  3. In that go to style section and You will get the custom variable named: --wp--custom--font-size--huge https://prnt.sc/-wgvVIx4wqbn

@github-actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kishanjasani <kishanjasani@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

carolinan commented Sep 2, 2024

Thank you for working on this.
In theme.json > Styles > Elements > H1 there is also a 70px font size that needs replacing.

@kishanjasani
Copy link
Contributor Author

kishanjasani commented Sep 2, 2024

@carolinan Updated the H1 tag font-size. Thanks!

juanfra
juanfra reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

I see that the new size is used, so those changes are workin well 🎉

Though, when viewing the pattern in the front-end it is not respecting the design as the text breaks in three lines. This is happening because the layout of the pattern is taking the max width of 645px, where the intention of the design is that it takes a full width and wrapping the content in the wide width.

Screen.Recording.2024-09-02.at.10.36.50.mov

We could move forward with this as is (with the changes that Carolina requested), in that case we'll need to address the layout issues in a new PR.

@carolinan
Copy link
Contributor

carolinan commented Sep 2, 2024

Yes the width is unrelated to this issue and PR.

@carolinan carolinan merged commit 8b71176 into WordPress:trunk Sep 2, 2024
@juanfra juanfra mentioned this pull request Sep 2, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@juanfra juanfra juanfra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kishanjasani kishanjasani

Labels

[Component] Block Patterns [Component] theme.json [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add additional font sizes as a custom CSS property in theme.json

3 participants

@kishanjasani @carolinan @juanfra