Skip to content

Add check for MACOSX#414

Closed
TeBenachi wants to merge 5 commits intoWordPress:masterfrom
TeBenachi:check-directory-macosx
Closed

Add check for MACOSX#414
TeBenachi wants to merge 5 commits intoWordPress:masterfrom
TeBenachi:check-directory-macosx

Conversation

@TeBenachi
Copy link
Copy Markdown
Contributor

Add directory check for __MACOSX

@kafleg
Copy link
Copy Markdown
Member

kafleg commented Jan 11, 2022

Checked this PR in windows pc, but it's not showing anything in the theme check page.

  • Windows PC
  • Laragon Localhost
  • WP 5.8.3
  • FSE theme with MACOSX file in it

Anyone with windows PC can test this?

$this->error[] = sprintf(
'<span class="tc-lead tc-required">%s</span>: %s',
__( 'REQUIRED', 'theme-check' ),
__( 'Please remove any extraneous directories like <strong>.git</strong>, <strong>.svn</strong> or <strong>__MACOSX</strong> from the ZIP file before uploading it. For the <a href="https://make.wordpress.org/themes/handbook/review/required/#9-files">List of disallowed files</a>', 'theme-check' )
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that the error message only includes the __MACOSX
I'm not sure I have write access to the fork though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants