Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: WordPress/site-health-troubleshooting
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0970ae384be8
Choose a base ref
...
head repository: WordPress/site-health-troubleshooting
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f00f6d37c265
Choose a head ref
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Sep 27, 2024

  1. Introduce a Types class to help with future typecasting. 

    The nature of the plugin is that it may be in environments with less than great code, it may not return the expected types for example.

This introduces the `Types` class, which aims to provide tools for the Troubleshooting plugin to ensure expected types are used within itself, and in the future, also alert of plugins or themes that may be incorrectly returning types for what the troubleshooting plugin does.

This also removes the typecast from the Troubleshoot class, so that it does not cause fatal errors on activation where other plugins may not be appropriately modifying the plugins page.
    @Clorith
    Clorith committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ffdee59 View commit details
    Browse the repository at this point in the history

  2. Automatically run, and use, the bundled wp-env environment for e2e tests

    @Clorith
    Clorith committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    56e436a View commit details
    Browse the repository at this point in the history

  3. Introduce an autoloader to simplify the process of using classes acro… 

    …ss the plugin
    @Clorith
    Clorith committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4fd0efb View commit details
    Browse the repository at this point in the history

  4. Proactively remove some strict typecastsa nd stick to doc-blocks unti… 

    …l we have a reliable means to handle them globally in the plugin.

This is important as a fatal error when troubleshooting mode is being enabled or disabled may leave a site in an unrecoverable state if the right preconditions are met.
    @Clorith
    Clorith committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f00f6d3 View commit details
    Browse the repository at this point in the history
Loading