Repository navigation
Fix E2E error notice selector for WordPress trunk - #572
Open
faisalahammad wants to merge 1 commit into
Open
faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
Gutenberg trunk renders editor notices with notices-inline-notices__* classes instead of the legacy components-notice markup, so the block validation tests could not find the error notice even though it shows. Match both markups.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two E2E tests fail on the
E2E - WP trunkjob on every open PR (e.g. #565, #539, #571):tests/e2e/block-testimonial.spec.ts› should validate required quote field in testimonial blocktests/e2e/block-v3-features.spec.ts› should validate required fields on publishBoth time out waiting for
.components-notice.is-error .components-notice__contentafter clicking Publish with an empty required field.This is not a plugin bug. The CI failure screenshot and trace show the validation still works on trunk: the publish is blocked and the editor shows "An ACF Block on this page requires attention before you can save." Gutenberg trunk now renders editor notices with new markup (
div.notices-inline-notices__notice.is-errorwith the text in a childspan) instead ofdiv.components-notice.is-error > div.components-notice__content, so the old selector no longer matches.This PR makes the locator in both tests match either markup:
Testing
Locally with
npm run test:e2e -- tests/e2e/block-testimonial.spec.ts tests/e2e/block-v3-features.spec.ts:WP_ENV_CORE=WordPress/WordPress, 7.2-beta1-64690): both tests fail with the old selector and all 6 tests in the two specs pass with this change.See #571
Use of AI Tools
Claude Code was used to find the cause and write the fix. I reviewed and tested the changes before submitting.