Repository navigation
Fix block validation E2E tests on WordPress trunk - #569
Open
cbravobernal wants to merge 2 commits into
Open
cbravobernal wants to merge 2 commits into
cbravobernal wants to merge 2 commits into
Conversation
WordPress trunk renders editor notices with new markup that no longer includes .components-notice__content, so locate the notice by its message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
E2E - WP trunk / Shard 2/4job fails on two tests:block-testimonial.spec.ts› should validate required quote field in testimonial blockblock-v3-features.spec.ts› should validate required fields on publishWordPress trunk now renders editor notices with a new Notice component (
notices-inline-notices__notice is-error, text in a hashed__descriptionspan), so.components-notice.is-error .components-notice__contentno longer matches. The notice itself is shown as expected; the failure trace shows "An ACF Block on this page requires attention before you can save." in the editor notices area.Both tests now locate the notice by its message, which works with the old and new markup. Test-only change.
Closes
Use of AI Tools
Authored with Claude Code (Claude Opus 5.5): diagnosed the failure from the Playwright trace and wrote the change. Reviewed by me.
🤖 Generated with Claude Code