Skip to content

phpstan fixes (includes/admin/*) #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

phpstan fixes (includes/admin/*) #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions bin/baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,5 @@
parameters:
ignoreErrors:
-
message: '#^Access to an undefined property ACF_Admin_Field_Groups\:\:\$not_found_label\.$#'
identifier: property.notFound
count: 1
path: ../includes/admin/post-types/admin-field-groups.php

-
message: '#^Action callback returns array but should not return anything\.$#'
identifier: return.void
count: 1
path: ../includes/admin/post-types/admin-field-groups.php

-
message: '#^Class ACF_Admin_Post_type referenced with incorrect case\: ACF_Admin_Post_Type\.$#'
identifier: class.nameCase
count: 1
path: ../includes/admin/post-types/admin-post-type.php

-
message: '#^Access to an undefined property ACF_Admin_Post_Types\:\:\$not_found_label\.$#'
identifier: property.notFound
count: 1
path: ../includes/admin/post-types/admin-post-types.php

-
message: '#^Access to an undefined property ACF_Admin_Taxonomies\:\:\$not_found_label\.$#'
identifier: property.notFound
count: 1
path: ../includes/admin/post-types/admin-taxonomies.php

-
message: '#^Access to an undefined property ACF_Admin_UI_Options_Pages\:\:\$not_found_label\.$#'
identifier: property.notFound
count: 1
path: ../includes/admin/post-types/class-acf-admin-ui-options-pages.php

-
message: '#^Variable \$field might not be defined\.$#'
identifier: variable.undefined
Expand Down
7 changes: 7 additions & 0 deletions includes/admin/admin-internal-post-type-list.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ class ACF_Admin_Internal_Post_Type_List {
*/
public $is_pro_feature = false;

/**
* The label for the "not found" message.
*
* @var string
*/
public $not_found_label = '';

/**
* Constructs the class.
*/
Expand Down
2 changes: 1 addition & 1 deletion includes/admin/post-types/admin-field-groups.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class ACF_Admin_Field_Groups extends ACF_Admin_Internal_Post_Type_List {
public function __construct() {
add_action( 'admin_menu', array( $this, 'admin_menu' ), 7 );
add_action( 'load-edit.php', array( $this, 'handle_redirection' ) );
add_action( 'post_class', array( $this, 'get_admin_table_post_classes' ), 10, 3 );
add_filter( 'post_class', array( $this, 'get_admin_table_post_classes' ), 10, 3 );

parent::__construct();
}
Expand Down
2 changes: 1 addition & 1 deletion includes/admin/post-types/admin-post-type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*
* All the logic for editing a post type.
*/
class ACF_Admin_Post_type extends ACF_Admin_Internal_Post_Type {
class ACF_Admin_Post_Type extends ACF_Admin_Internal_Post_Type {

/**
* The slug for the internal post type.
Expand Down
Loading