Skip to content

Upgrade Node.js action version from 20 to 24 - #227

Merged
desrosj merged 6 commits into
WordPress:trunkfrom
wwahammy:patch-1
Mar 17, 2026
Merged

desrosj merged 6 commits into
WordPress:trunkfrom
wwahammy:patch-1

Conversation

@wwahammy

@wwahammy wwahammy commented Mar 12, 2026 •

Copy link
Copy Markdown
Contributor

What?

Switch Node version for the action runner from Node 20 to Node 24

Why?

The Node 20 runner is deprecated and will be removed. Currently, it's printing out warning messages. Seems wise to get that cleaned up now rather than later.

How?

  1. switch the runner version
  2. change the minimum version of Node to >= 24 in package.json and run npm install

Testing Instructions

That's a good question. I'm not quite sure on the best way to test this.

@desrosj desrosj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this, @wwahammy! Few small minor suggestions and then this should be ready to go!

Comment thread package.json Outdated
Comment thread package.json Outdated
wwahammy and others added 2 commits March 16, 2026 17:25
Co-authored-by: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com>
Co-authored-by: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com>
@wwahammy
wwahammy requested a review from desrosj March 16, 2026 22:26
@wwahammy

Copy link
Copy Markdown
Contributor Author

@desrosj thanks for the feedback, I've committed both suggestions.

@desrosj desrosj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, noticed a few more things, @wwahammy.

  • The .nvmrc file needs to be updated from 20 to 24.
  • The lock file still contains the old values for engines.

@wwahammy
wwahammy requested a review from desrosj March 17, 2026 01:22
@wwahammy

Copy link
Copy Markdown
Contributor Author

No problem @desrosj, I've handled that.

@desrosj desrosj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wwahammy!

@desrosj
desrosj merged commit 3e0f461 into WordPress:trunk Mar 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants