Externalize format-library to fix missing link button#97
Merged
Conversation
Without externalization, the format-library registers format types (bold, italic, link) in a bundled copy of the rich-text registry, while the externalized block-editor reads from the global registry. This mismatch caused the link button to be missing from the toolbar. See #95
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the missing “link” (and other rich text format) toolbar buttons in the Press This editor by ensuring @wordpress/format-library uses WordPress core’s shared wp.richText format registry (instead of a bundled private registry).
Changes:
- Externalizes
@wordpress/format-libraryin the custom webpack externals map so it resolves to the core globalwp.formatLibrary.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@wordpress/format-libraryto the webpack externals map so it shares the same globalwp.richTextformat registry as the externalized@wordpress/block-editorTest plan
Fixes #95