Repository navigation
chore(lint): resolve JSDoc warnings from wp-scripts 36 - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the 31 lint warnings that
@wordpress/eslint-plugin27 (via@wordpress/scripts36) started reporting insrc/. Only doc comments change; no code does.jsdoc/reject-function-type(24): each{Function}is now the callback's real signature, taken from how it is called, for example{(images: string[]) => void}or{(status: string, options?: Object) => void}.jsdoc/escape-inline-tags(7): package names such as@wordpress/editorin doc comments are now wrapped in backticks, so they are not read as JSDoc tags.lint-js --fixrealigned the affected@paramblocks to the wider type column, which accounts for most of the diff.Testing
npm run lint: 0 errors, 0 warnings (was 31 warnings).npm run buildcompiles;npm run test:unit: 364 passed.