Repository navigation
Conversation
wp_presence_sanitize_checkbox() had no @Covers tests; adds cases for truthy, falsy, and the PHP-falsy string '0' edge case. The early-return guard in wp_delete_expired_presence_data() that fires when batch_size or max_passes is filtered to below one was also untested; adds a test that seeds an expired row, filters batch_size to 0, and asserts the row survives.
Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
============================================
+ Coverage 97.51% 97.56% +0.04%
Complexity 269 269
============================================
Files 30 30
Lines 4388 4388
============================================
+ Hits 4279 4281 +2
+ Misses 109 107 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #895
Two untested code paths: `wp_presence_sanitize_checkbox()` had no `@covers` tests at all, and the early-return guard in `wp_delete_expired_presence_data()` that fires when a filter sets `batch_size` or `max_passes` below one was unreachable by the existing three cleanup tests (all of which pass values ≥ 1).
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): claude-sonnet-4-6
Used for: Test implementation; reviewed and verified by contributor.