Skip to content

fix: leave post locks intact when a user logs out - #892

Open
noruzzamans wants to merge 2 commits into
WordPress:mainfrom
noruzzamans:fix/890-preserve-post-locks-on-logout
Open

noruzzamans wants to merge 2 commits into
WordPress:mainfrom
noruzzamans:fix/890-preserve-post-locks-on-logout

Conversation

@noruzzamans

Copy link
Copy Markdown
Contributor

Fixes #890

Deletes only client presence rows when removing a user's presence so post locks held in other browser sessions survive until expiry.

Use of AI Tools

AI assistance: Yes
Tool(s): Google Gemini
Model(s): Gemini 3.8 Flash
Used for: Drafting query update and regression test; verified locally with PHPUnit, PHPCS, PHPStan, and npm run check.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

🛝 WordPress Playgrounds

Built from c389cdc

Post locks RTC Synced patterns Settings
Single site Launch post locks, single site Launch RTC, single site Launch synced patterns, single site Launch settings, single site
Multisite Launch post locks, multisite Launch RTC, multisite Launch synced patterns, multisite Launch network settings, multisite

@noruzzamans
noruzzamans marked this pull request as ready for review October 25, 2026 03:59
@github-actions

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props noruzzaman, huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

github-actions Bot added a commit that referenced this pull request Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.42%. Comparing base (2e26f44) to head (c389cdc).

❌ Your patch check has failed because the patch coverage (69.23%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #892      +/-   ##
============================================
- Coverage     97.51%   97.42%   -0.09%     
  Complexity      269      269              
============================================
  Files            30       30              
  Lines          4388     4395       +7     
============================================
+ Hits           4279     4282       +3     
- Misses          109      113       +4     
Flag Coverage Δ
multisite 97.42% <69.23%> (-0.09%) ⬇️
phpunit 77.56% <69.23%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging out in one browser releases post locks held in another

1 participant